On Tue, Feb 20, 2018 at 11:05:24AM +0000, Ard Biesheuvel wrote: > BaseDebugLibSerialPort is not suitable for use by DXE_RUNTIME_DRIVER > modules, so blacklist it for use by such modules. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > b/MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > index 823511b22f6b..25da1fb9363a 100644 > --- a/MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > +++ b/MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > @@ -21,7 +21,7 @@ [Defines] > FILE_GUID = BB83F95F-EDBC-4884-A520-CD42AF388FAE > MODULE_TYPE = BASE > VERSION_STRING = 1.0 > - LIBRARY_CLASS = DebugLib > + LIBRARY_CLASS = DebugLib|SEC PEI_CORE PEIM DXE_CORE > DXE_DRIVER DXE_SMM_DRIVER DXE_SAL_DRIVER UEFI_DRIVER UEFI_APPLICATION > SMM_CORE MM_STANDALONE MM_CORE_STANDALONE
Not a comment on this patch as such (which looks sensible to me), but what you're doing here isn't blacklisting DXE_RUNTIME_DRIVER, but rather whitelisting every other module type. Could we use a ! operator added to the syntax? / Leif > CONSTRUCTOR = BaseDebugLibSerialPortConstructor > > # > -- > 2.11.0 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel