Arvind: Could you give one example to explain this usage? ---------- Forwarded message ---------- From: Arvind Prasanna <arvindprasa...@gmail.com<mailto:arvindprasa...@gmail.com>> Date: Sat, Mar 10, 2018 at 3:18 AM Subject: [PATCH] edksetup.sh: Update help section regarding positional To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> Cc: Arvind Prasanna <arvindprasa...@gmail.com<mailto:arvindprasa...@gmail.com>>
It is possible to source edksetup.sh from another script. If the calling/sourcing script has any positional parameters set, those are incorrectly accounted for in edksetup.sh while sourcing it resulting in the the help section always being shown. This patch updates the help section advising the user about these set positional parameters so they can be unset prior to sourcing edksetup.sh. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Arvind Prasanna <arvindprasa...@gmail.com<mailto:arvindprasa...@gmail.com>> --- edksetup.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/edksetup.sh b/edksetup.sh index 93d6525..a3d5560 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -42,6 +42,8 @@ function HelpMsg() echo Please note: This script must be \'sourced\' so the environment can be changed. echo ". $SCRIPTNAME" echo "source $SCRIPTNAME" + echo "If this script is being sourced from another script, please ensure that the" + echo "sourcing/calling script has no set postional parameters." } function SetWorkspace() -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
