Arvind: The caller script may set the supported parameters by edksetup.sh. So, the notes may be updated not to set the unknown parameter.
Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Arvind > Prasanna > Sent: Tuesday, March 13, 2018 1:44 PM > To: Arvind Prasanna <[email protected]> > Cc: [email protected]; Gao, Liming <[email protected]> > Subject: Re: [edk2] [PATCH v2] edksetup.sh: Update help section regarding > positional parameters > > Please ignore this and follow my original email thread. Git did not chain > this as I had expected. > > - Arvind. > > > > On Tue, Mar 13, 2018 at 1:38 AM, Arvind Prasanna <[email protected]> > wrote: > > > It is possible to source edksetup.sh from another script. If the > > calling/sourcing script has any positional parameters set, those are > > incorrectly accounted for in edksetup.sh while sourcing it resulting in > > the the help section always being shown. This patch updates the help > > section advising the user about these set positional parameters so they > > can be unset prior to sourcing edksetup.sh. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Arvind Prasanna <[email protected]> > > > > Changes in v2: > > - Fixed a typo. > > - Minor rewording. > > --- > > edksetup.sh | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/edksetup.sh b/edksetup.sh > > index 93d6525..e85fbf2 100755 > > --- a/edksetup.sh > > +++ b/edksetup.sh > > @@ -42,6 +42,8 @@ function HelpMsg() > > echo Please note: This script must be \'sourced\' so the environment > > can be changed. > > echo ". $SCRIPTNAME" > > echo "source $SCRIPTNAME" > > + echo "If this script is being sourced from another script, please > > ensure that the" > > + echo "sourcing script has no set positional parameters." > > } > > > > function SetWorkspace() > > -- > > 2.7.4 > > > > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
