Reviewed-by: Evan Lloyd <evan.ll...@arm.com>
> -----Original Message----- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd <n...@arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes- > f...@arm.com>; leif.lindh...@linaro.org; ard.biesheu...@linaro.org > Subject: [edk2] [PATCH v3 06/16] ArmPlatformPkg: PL111Lcd: Replace > magic number with macro > > From: Girish Pathak <girish.pathak at arm.com> > > Minor code change, replaces magic number with macro in LCD disable. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak <girish.pat...@arm.com> > Signed-off-by: Evan Lloyd <evan.ll...@arm.com> > Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > index > cb64c57dd79f3bb1345e4d3dbda7f5b3ce859f40..287e3ca272c0c19f8045a > 3bf4e69a092d8da6fd8 100644 > --- a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > +++ b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > @@ -119,8 +119,7 @@ LcdSetMode ( > } > > // Disable the CLCD_LcdEn bit > - LcdControl = MmioRead32 (PL111_REG_LCD_CONTROL); > - MmioWrite32 (PL111_REG_LCD_CONTROL, LcdControl & ~1); > + MmioAnd32 (PL111_REG_LCD_CONTROL, ~PL111_CTRL_LCD_EN); > > // Set Timings > MmioWrite32 ( > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
