On 13 July 2018 at 10:12, Marcin Wojtas <m...@semihalf.com> wrote: > Hi, > > The second version of the ICU patchset brings all corrections > according to all review remarks. They were mostly style / naming > - detailed list can be found in the changelog below. > > The patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/icu-upstream-r20180713 > > I'm looking forward to review and any comments/remarks. > > Best regards, > Marcin > > Changelog > v1 -> v2 > * 1,6 > - Add Ard's RB > > * 2 > - Change ICU_IRQ_TYPE to IcuIrqTypeLevel / IcuIrqTypeEdge > > * 3 > - Use EFI_PHYSICAL_ADDRESS > > * 4 > - Put a space after { and before } > - Change enum values to IcuGroupXxx format > > * 5 > - Use ICU_GROUP_REGISTER_BASE_OFFSET instead of a raw value in macros > - Add missing parentheses and use sizeof (UINT32) in ICU_INT_CFG macro > - Use mEfiExitBootServicesEvent - not initialized and STATIC > - s/IcuConfigDefault/IcuInitialConfig/ > - Break to long lines > > Marcin Wojtas (6): > Marvell/Armada70x0Db: Set correct CP110 count > Marvell/Library: Introduce ArmadaIcuLib class > Marvell/Library: Armada7k8kSoCDescLib: Enable getting CP base address > Marvell/Library: Armada7k8kSoCDescLib: Introduce ICU information > Marvell/Library: Implement common ArmadaIcuLib > Marvell/Armada7k8k: Enable ICU configuration >
Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Pushed as 80f6be6eb12b..bd325517ba42 (with 5/6 updated to the v3 version) > Silicon/Marvell/Marvell.dec > | 1 + > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > | 1 + > Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc > | 7 +- > Silicon/Marvell/Armada7k8k/Drivers/PlatInitDxe/PlatInitDxe.inf > | 1 + > Silicon/Marvell/Library/IcuLib/IcuLib.inf > | 38 +++ > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h > | 12 + > Silicon/Marvell/Include/Library/ArmadaIcuLib.h > | 45 +++ > Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h > | 39 +++ > Silicon/Marvell/Library/IcuLib/IcuLib.h > | 47 +++ > Silicon/Marvell/Armada7k8k/Drivers/PlatInitDxe/PlatInitDxe.c > | 2 + > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c > | 50 +++ > Silicon/Marvell/Library/IcuLib/IcuLib.c > | 317 ++++++++++++++++++++ > 12 files changed, 558 insertions(+), 2 deletions(-) > create mode 100644 Silicon/Marvell/Library/IcuLib/IcuLib.inf > create mode 100644 Silicon/Marvell/Include/Library/ArmadaIcuLib.h > create mode 100644 Silicon/Marvell/Library/IcuLib/IcuLib.h > create mode 100644 Silicon/Marvell/Library/IcuLib/IcuLib.c > > -- > 2.7.4 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
