On 08/09/18 16:33, [email protected] wrote: > From: Marc-André Lureau <[email protected]> > > The library constructor is not being called because of the typo, > causing TPM2 detection/initialization to fail. > > This fixes OVMF TPM2 regression since commit f15cb995bb38. > https://bugzilla.tianocore.org/show_bug.cgi?id=1075 > > Cc: Laszlo Ersek <[email protected]> > Cc: Zhang Chao B <[email protected]> > Cc: Long Qin <[email protected]> > Fixes: f15cb995bb3880b77e15afe6facd3da05e599a17 > Contributed-under: TianoCore Contribution Agreement 1.1 > Reported-by: Ricardo Araújo <[email protected]> > Signed-off-by: Marc-André Lureau <[email protected]> > --- > SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf > b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf > index b6867bc4fff4..c6d23c93fe93 100644 > --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf > +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf > @@ -28,7 +28,7 @@ > MODULE_TYPE = BASE > VERSION_STRING = 1.0 > LIBRARY_CLASS = Tpm2DeviceLib|PEIM DXE_DRIVER > DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER > - Constructor = Tpm2DeviceLibConstructor > + CONSTRUCTOR = Tpm2DeviceLibConstructor > # > # The following information is for reference only and not required by the > build tools. > # >
+ Jiewen (see "SecurityPkg" in "Maintainers.txt"). Reviewed-by: Laszlo Ersek <[email protected]> I will wait one day so that Chao, Jiewen and/or Qin can ACK the patch as well. I will push the patch tomorrow (definitely before the upcoming stable tag). Note: I would like to push this patch myself because of the non-ASCII characters in the metadata. Previously, similar patches have been messed up, regarding the "Author" field (see 4cc2b63bd829 and 73ee3abab1a1). I should be able to handle the git-am / git-push cleanly on my side though (see a39e72267034 and ab9e11da6651). Thanks! Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
