HI Lureau: Thanks for you investigation. It is my typo! The reason why we didn’t have this issue is that we only use TPM2InstanceLib. That lib use the correct definition.
-----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of [email protected] Sent: Thursday, August 9, 2018 10:33 PM To: [email protected] Cc: Laszlo Ersek <[email protected]>; Zhang, Chao B <[email protected]>; Long, Qin <[email protected]> Subject: [edk2] [PATCH 1/1] SecurityPkg/Library/Tpm2DeviceLibDTpm: fix s/Constructor/CONSTRUCTOR From: Marc-André Lureau <[email protected]> The library constructor is not being called because of the typo, causing TPM2 detection/initialization to fail. This fixes OVMF TPM2 regression since commit f15cb995bb38. https://bugzilla.tianocore.org/show_bug.cgi?id=1075 Cc: Laszlo Ersek <[email protected]> Cc: Zhang Chao B <[email protected]> Cc: Long Qin <[email protected]> Fixes: f15cb995bb3880b77e15afe6facd3da05e599a17 Contributed-under: TianoCore Contribution Agreement 1.1 Reported-by: Ricardo Araújo <[email protected]> Signed-off-by: Marc-André Lureau <[email protected]> --- SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf index b6867bc4fff4..c6d23c93fe93 100644 --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.inf @@ -28,7 +28,7 @@ MODULE_TYPE = BASE VERSION_STRING = 1.0 LIBRARY_CLASS = Tpm2DeviceLib|PEIM DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER - Constructor = Tpm2DeviceLibConstructor + CONSTRUCTOR = Tpm2DeviceLibConstructor # # The following information is for reference only and not required by the build tools. # -- 2.18.0.547.g1d89318c48 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
