On 08/10/18 10:47, Zeng, Star wrote:
> I suggest merging this patch with
> https://lists.01.org/pipermail/edk2-devel/2018-August/027953.html to one
> patch.
> And remember to update the new patch's version.
There's another thing to remember please, when posting the new version
of the series:
for every patch X:
if patch X has received Reviewed-by tags in the v1 review, and
patch X is not changed between v1 and v2
then
the v2 posting of patch X should carry the Reviewed-by tags from
the v1 review.
I would very much *not* like to re-review those patches that I have
reviewed already, and are not changed in the v2 iteration.
In practice this means editing the commit message of every *unchanged*
patch, and appending the Reviewed-by tags from the mailing list for that
patch, at the bottom of the commit message. Use git-rebase + "reword".
(Sorry if I shouldn't have spelled this out; I'm unsure how much
experience Shenglei has with git.)
Thanks
Laszlo
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
