Reviewed-by: Ruiyu Ni <ruiyu...@intel.com>

Thanks/Ray

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Thursday, August 16, 2018 1:32 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>
> Subject: [PATCH 4/5] ShellPkg: Remove unused PCDs
> 
> The PCDs below are unused, so they have been removed from inf.
> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize
> gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength
> gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize
> gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize
> gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize
> gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize
> gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength
> 
> Cc: Jaben Carsey <jaben.car...@intel.com>
> Cc: Ruiyu Ni <ruiyu...@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zh...@intel.com>
> ---
>  ShellPkg/Application/Shell/Shell.inf                           | 2 --
>  ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf             | 2 --
>  ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf  |
> 3 ---
>  ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 1 -
>  .../UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf  | 2 --
>  5 files changed, 10 deletions(-)
> 
> diff --git a/ShellPkg/Application/Shell/Shell.inf
> b/ShellPkg/Application/Shell/Shell.inf
> index d89f85bb76..83049844d6 100644
> --- a/ShellPkg/Application/Shell/Shell.inf
> +++ b/ShellPkg/Application/Shell/Shell.inf
> @@ -102,10 +102,8 @@
>    gEfiShellPkgTokenSpaceGuid.PcdShellRequireHiiPlatform     ## CONSUMES
>    gEfiShellPkgTokenSpaceGuid.PcdShellSupportFrameworkHii    ## CONSUMES
>    gEfiShellPkgTokenSpaceGuid.PcdShellPageBreakDefault       ## CONSUMES
> -  gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize      ## CONSUMES
>    gEfiShellPkgTokenSpaceGuid.PcdShellInsertModeDefault      ## CONSUMES
>    gEfiShellPkgTokenSpaceGuid.PcdShellScreenLogCount         ## CONSUMES
> -  gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength          ## CONSUMES
>    gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize        ## CONSUMES
>    gEfiShellPkgTokenSpaceGuid.PcdShellForceConsole           ## CONSUMES
>    gEfiShellPkgTokenSpaceGuid.PcdShellSupplier               ## CONSUMES
> diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
> b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
> index cedb333b28..c35a3087cf 100644
> --- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
> +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
> @@ -69,5 +69,3 @@
>    gEfiLoadedImageDevicePathProtocolGuid                   ##
> SOMETIMES_CONSUMES
>    gEfiHiiPackageListProtocolGuid                          ## CONSUMES
> 
> -[Pcd]
> -  gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize   ## CONSUMES
> diff --git
> a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
> b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
> index 8fd3bbd5df..2d07b32266 100644
> ---
> a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
> +++
> b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
> @@ -71,8 +71,5 @@
>    gEfiHiiPackageListProtocolGuid                          ## CONSUMES
>    gEfiShellDynamicCommandProtocolGuid                     ## PRODUCES
> 
> -[Pcd]
> -  gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize   ## CONSUMES
> -
>  [DEPEX]
>    TRUE
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> index e5e007bef3..a795fb92de 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> @@ -353,5 +353,4 @@
>    gEfiAdapterInfoUndiIpv6SupportGuid                      ## 
> SOMETIMES_CONSUMES
> ## GUID
> 
>  [Pcd.common]
> -  gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize      ## CONSUMES
>    gEfiShellPkgTokenSpaceGuid.PcdShellIncludeNtGuids       ## CONSUMES
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi
> b.inf
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi
> b.inf
> index 3ea51ec082..ec1f87ae19 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi
> b.inf
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi
> b.inf
> @@ -119,8 +119,6 @@
> 
>  [Pcd]
>    gEfiShellPkgTokenSpaceGuid.PcdShellProfileMask              ## CONSUMES
> -  gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize        ## CONSUMES
> -  gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength      ##
> CONSUMES
> 
>  [Protocols]
>    gEfiPciRootBridgeIoProtocolGuid             ## SOMETIMES_CONSUMES
> --
> 2.18.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to