On 08/16/18 08:30, Zeng, Star wrote: > Hi Shenglei, > > BaseLib is not belong to MdeModulePkg, please spit it into separated patch.
I'd also like to review v2 of this series, please consider CC'ing me on it. Thanks, Laszlo > > Thanks, > Star > -----Original Message----- > From: Zhang, Shenglei > Sent: Thursday, August 16, 2018 1:32 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Dong, Eric <eric.d...@intel.com> > Subject: [PATCH 1/5] MdeModulePkg: Remove unused PCDs > > The PCDs below are unused, so they have been removed from inf. > gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleMax > gEfiMdeModulePkgTokenSpaceGuid.PcdSystemRebootAfterCapsuleProcessFlag > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeSubClassCapsule > gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeProcessCapsulesBegin > gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeProcessCapsulesEnd > gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdatingFirmware > gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdateFirmwareSuccess > gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdateFirmwareFailed > gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeResettingSystem > gEfiMdeModulePkgTokenSpaceGuid.PcdExtFpdtBootRecordPadSize > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask > > Cc: Star Zeng <star.z...@intel.com> > Cc: Eric Dong <eric.d...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei <shenglei.zh...@intel.com> > --- > .../Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf | 11 ----------- > .../FirmwarePerformanceDxe.inf | 1 - > MdePkg/Library/BaseLib/BaseLib.inf | 1 - > 3 files changed, 13 deletions(-) > > diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf > b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf > index 342df9e99c..d5e87cb97b 100644 > --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf > +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf > @@ -56,17 +56,6 @@ > HobLib > BmpSupportLib > > -[Pcd] > - gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleMax > ## CONSUMES > - gEfiMdeModulePkgTokenSpaceGuid.PcdSystemRebootAfterCapsuleProcessFlag > ## CONSUMES > - > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeSubClassCapsule > ## CONSUMES > - gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeProcessCapsulesBegin > ## CONSUMES > - gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeProcessCapsulesEnd > ## CONSUMES > - gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdatingFirmware > ## CONSUMES > - gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdateFirmwareSuccess > ## CONSUMES > - gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeUpdateFirmwareFailed > ## CONSUMES > - gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeResettingSystem > ## CONSUMES > > [Protocols] > gEsrtManagementProtocolGuid ## CONSUMES > diff --git > a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf > > b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf > index 983ce41b48..023ab00c7c 100644 > --- > a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf > +++ > b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.inf > @@ -73,7 +73,6 @@ > [Pcd] > gEfiMdeModulePkgTokenSpaceGuid.PcdProgressCodeOsLoaderLoad ## CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdProgressCodeOsLoaderStart ## CONSUMES > - gEfiMdeModulePkgTokenSpaceGuid.PcdExtFpdtBootRecordPadSize ## CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId ## CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId ## CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision ## CONSUMES > diff --git a/MdePkg/Library/BaseLib/BaseLib.inf > b/MdePkg/Library/BaseLib/BaseLib.inf > index a1b5ec4b75..4ae8a0b05a 100644 > --- a/MdePkg/Library/BaseLib/BaseLib.inf > +++ b/MdePkg/Library/BaseLib/BaseLib.inf > @@ -643,7 +643,6 @@ > gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength ## > SOMETIMES_CONSUMES > gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength ## > SOMETIMES_CONSUMES > gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength ## > SOMETIMES_CONSUMES > - gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask ## > SOMETIMES_CONSUMES > > [FeaturePcd] > gEfiMdePkgTokenSpaceGuid.PcdVerifyNodeInList ## CONSUMES > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
