On 6 September 2018 at 14:24, Laszlo Ersek <[email protected]> wrote: > On 09/06/18 12:28, Ard Biesheuvel wrote: >> On 9 August 2018 at 17:41, <[email protected]> wrote: >>> The InvalidChars[] array is only used in function IsValidCommandName(). >>> The array should be deleted also, I think. >>> >> >> Indeed, and for this reason this patch has now broken the build for >> clang. Please fix. > > I agree about InvalidChars being unused, post-22cf747fcf75. I just can't > reproduce the build error, with CLANG38 (3.8.1). The command > > build -a X64 -p ShellPkg/ShellPkg.dsc -b RELEASE -t CLANG38 \ > -m ShellPkg/Application/Shell/Shell.inf > > seems to work for me, also with "-b DEBUG". > > What differs on your end? >
Not sure what the exact difference is, but I am using CLANG35 profile: https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/3176/consoleFull _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
