Laszlo: I ask Shenglei to provide the patch to fix this failure. Today, I meet with the failure in XCODE5 tool chain.
Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Laszlo > Ersek > Sent: Friday, September 7, 2018 12:19 AM > To: Gao, Liming <[email protected]>; Ard Biesheuvel > <[email protected]> > Cc: Carsey, Jaben <[email protected]>; Ni, Ruiyu <[email protected]>; > [email protected] > Subject: Re: [edk2] [PATCH] ShellPkg Shell: Remove redundant functions > > On 09/06/18 17:22, Gao, Liming wrote: > > The build log shows the error message. I agree to remove this unused global > > variable InvalidChars in this patch. > > > > /home/buildslave/workspace/leg-virt-tianocore-edk2-upstream/edk2/ShellPkg/Application/Shell/Shell.c:2754:21: > > error: unused > variable 'InvalidChars' [-Werror,-Wunused-const-variable] > > 12:23:26 STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', > > L'\\', L'/', L'\"', 0x0001, 0x0002}; > > OK... should we file a TianoCore BZ about this and wait until it gets > assigned and fixed, should we ask Shenglei just on the list to post a > follow-up (like Ard already did), or should one of us that actually > encounters the error post the one-liner patch? > > (I would have already posted the patch if I could actually reproduce the > error.) > > Thanks > Laszlo > > >> -----Original Message----- > >> From: edk2-devel [mailto:[email protected]] On Behalf Of Ard > >> Biesheuvel > >> Sent: Thursday, September 6, 2018 8:31 PM > >> To: Laszlo Ersek <[email protected]> > >> Cc: Carsey, Jaben <[email protected]>; Ni, Ruiyu > >> <[email protected]>; [email protected] > >> Subject: Re: [edk2] [PATCH] ShellPkg Shell: Remove redundant functions > >> > >> On 6 September 2018 at 14:24, Laszlo Ersek <[email protected]> wrote: > >>> On 09/06/18 12:28, Ard Biesheuvel wrote: > >>>> On 9 August 2018 at 17:41, <[email protected]> wrote: > >>>>> The InvalidChars[] array is only used in function IsValidCommandName(). > >>>>> The array should be deleted also, I think. > >>>>> > >>>> > >>>> Indeed, and for this reason this patch has now broken the build for > >>>> clang. Please fix. > >>> > >>> I agree about InvalidChars being unused, post-22cf747fcf75. I just can't > >>> reproduce the build error, with CLANG38 (3.8.1). The command > >>> > >>> build -a X64 -p ShellPkg/ShellPkg.dsc -b RELEASE -t CLANG38 \ > >>> -m ShellPkg/Application/Shell/Shell.inf > >>> > >>> seems to work for me, also with "-b DEBUG". > >>> > >>> What differs on your end? > >>> > >> > >> Not sure what the exact difference is, but I am using CLANG35 profile: > >> > >> https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/3176/consoleFull > >> _______________________________________________ > >> edk2-devel mailing list > >> [email protected] > >> https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
