Hi Marcin, Please give me some time to go through the series. I will provide feedbacks on these patches. Sorry for the possible delay.
Best Regards, Hao Wu From: Marcin Wojtas [mailto:[email protected]] Sent: Wednesday, September 12, 2018 3:29 PM To: edk2-devel-01 Cc: Wu, Hao A; Ard Biesheuvel; Tian, Feng; Kinney, Michael D; Gao, Liming; Leif Lindholm; [email protected]; [email protected]; Tomasz Michalec Subject: Re: [PATCH v2 0/4] SdMmc fixes Hi, So far there was one minor remark from Ard (about macro definition) - I would appreciate any comments before I can submit v3. Thanks, Marcin pt., 7 wrz 2018 o 13:04 Ard Biesheuvel <[email protected]<mailto:[email protected]>> napisał(a): +Hao On 7 September 2018 at 11:10, Marcin Wojtas <[email protected]<mailto:[email protected]>> wrote: > Hi, > > Answering the review request, I extracted SdMmcPciHcDxe driver fixes > from SdMmcOverride protocol modification. Comparing to v1, > patches are rebased onto the newest master branch and also a macro > is used instead of the raw value in SdMmcHcReset. > > Patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/sdmmc-fixes-r20180907 > > I'm looking forward to the comments and remarks. > > Best regards, > Marcin > > Changelog: > v1 -> v2 > * rebase on top of the newest master > * resolve conflicts after taking fixes out from new features > * 3/4 - use macro instead of raw value in SdMmcHcReset > > Marcin Wojtas (3): > MdeModulePkg/SdMmcPciHcDxe: Fix HS200 operation > MdeModulePkg/SdMmcPciHcDxe: Adjust eMMC clock and bus width sequence > MdeModulePkg/SdMmcPciHcDxe: Execute card detect only for RemovableSlot > > Tomasz Michalec (1): > MdeModulePkg/SdMmcPciHcDxe: Fix SdMmcHcReset to set only necesery bits > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 10 +++++ > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 39 +++++--------------- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 18 ++++++--- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 6 +-- > 4 files changed, 34 insertions(+), 39 deletions(-) > > -- > 2.7.4 > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
