The series is good to me. Reviewed-by: Hao Wu <[email protected]> I will push the changes and update the relating Bugzilla trackers.
Best Regards, Hao Wu > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of > Marcin Wojtas > Sent: Tuesday, September 18, 2018 4:59 PM > To: [email protected] > Cc: Tian, Feng; [email protected]; Wu, Hao A; [email protected]; Gao, > Liming; Kinney, Michael D > Subject: [edk2] [PATCH v4 0/3] SdMmc fixes > > Hi, > > The third version has shrunk once again - it turned > out the bus width / bus mode sequence modification > in eMMC high speed setting may not be needed. > Other than that, for remaining two patches add > bugzilla references and apply required modifications. > More details can be found in the changelog below. > > Patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open- > platform/commits/sdmmc-fixes-r20180918 > > I'm looking forward to the comments and remarks. > > Best regards, > Marcin > > Changelog: > v3 -> v4 > * rebase on top of the newest master > * add Hao Wu RB in 2/2 > * add references to according bugzilla entries > * remove changes in EmmcSwitchToHighSpeed () > * Use BIT0 directly and update error message in 1/2 > > v2 -> v3 > * rebase on top of the newest master > * remove changes in EmmcSwitchToHS200 () > * 2/3 - use BIT0 in macro > > v1 -> v2 > * rebase on top of the newest master > * resolve conflicts after taking fixes out from new features > * 3/4 - use macro instead of raw value in SdMmcHcReset > > > Marcin Wojtas (1): > MdeModulePkg/SdMmcPciHcDxe: Execute card detect only for RemovableSlot > > Tomasz Michalec (1): > MdeModulePkg/SdMmcPciHcDxe: Fix SdMmcHcReset to set only necesery bits > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 18 > ++++++++++++------ > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 8 ++++---- > 2 files changed, 16 insertions(+), 10 deletions(-) > > -- > 2.7.4 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
