On 9/21/2018 7:12 PM, Laszlo Ersek wrote:
On 09/21/18 09:25, Ruiyu Ni wrote:Two superficial comments: - edk2 prefers long parameter names, so I suggest replacing "R" in the macro definition with "Resource" - taking the parameter as a pointer is frequently considered more flexible. #define RESOURCE_VALID(Resource) ((Resource)->Base <= (Resource)->Limit) ... if (RESOURCE_VALID (&Bridge->Mem)) { ... Up to you -- if you like these, feel free to update the patch before pushing it (from my side anyway; you do need MdeModulePkg maintainer review as well).
Good comments. I will update the patch then commit.
With or without changes: Reviewed-by: Laszlo Ersek <[email protected]> Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
-- Thanks, Ray _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
