On 9/25/2018 11:13 AM, Zeng, Star wrote:
On 2018/9/25 10:47, Ni, Ruiyu wrote:
But then there will be a little inconsistent, for example OPERATION_TYPE
is only used by PciRootBridgeIo.c.
Since coding style document doesn't define clear rule for this (I also
don't like a coding style document with so many detailed restrictions.
This removes the fun from coding.), I agree there is inconsistency.
I agree moving mIoMmuProtocol to PciHostBridge.h.
I am happy to do that in a separate patch in V2.
Thanks. If we will only move mIoMmuProtocol, it can be in a separated
patch.
Star
Agree?
Thanks,
Star
With or without changes:
Reviewed-by: Laszlo Ersek <[email protected]>
Thanks
Laszlo
--
Thanks,
Ray
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
