On 09/25/18 05:44, Jiaxin Wu wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205 > > This patch is to add the driver usage/difference clarification > compared to IScsiDxe in NetworkPkg. > > Cc: Ye Ting <ting...@intel.com> > Cc: Fu Siyuan <siyuan...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wu Jiaxin <jiaxin...@intel.com> > --- > MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf > b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf > index c3b8c7d15a..cd6a2ef843 100644 > --- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf > +++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf > @@ -2,11 +2,21 @@ > # This module produces EFI iSCSI Initiator Name Protocol. > # > # This module produces EFI iSCSI Initiator Name Protocol upon EFI TCPv4 > Protocol > # and EFI DHCPv4 Protocol, to provide the capability to do the transport > for SCSI > # data over TCP/IP. It installs EFI HII Configuration Access Protocol to > provide > -# one way to configurate the iSCSI setting. > +# one way to configurate the iSCSI setting. This driver only supports IPv4 > network > +# stack. > +# > +# Notes: > +# 1) This driver can't co-work with the IScsiDxe driver in NetworkPkg. > +# 2) This driver might have some issues that have been fixed in the > IScsiDxe driver > +# in NetworkPkg. > +# 3) This driver supports less feature than the IScsiDxe driver in > NetworkPkg > +# (e.g. IPv6, Dns support for target URL configuration, iSCSI keyword > support). > +# 4) IScsiDxe driver in NetworkPkg is recommanded to use instead of this > one even > +# both of them can be used. > # > # Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR> > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD > License > # which accompanies this distribution. The full text of the license may be > found at >
Same comments as for patch #1. With those addressed: Reviewed-by: Laszlo Ersek <ler...@redhat.com> Thanks! Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
