Thanks the correction, I will refine all the patches according your comments before committing the patches.
Best Regards! Jiaxin > -----Original Message----- > From: Laszlo Ersek [mailto:[email protected]] > Sent: Tuesday, September 25, 2018 6:31 PM > To: Wu, Jiaxin <[email protected]>; [email protected] > Cc: Ye, Ting <[email protected]>; Fu, Siyuan <[email protected]> > Subject: Re: [Patch 6/6] NetworkPkg/UefiPxeBcDxe: Add the clarification > compared to UefiPxeBcDxe in MdeModulePkg. > > On 09/25/18 05:44, Jiaxin Wu wrote: > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205 > > > > This patch is to add the driver usage/difference clarification > > compared to UefiPxeBcDxe in MdeModulePkg. > > > > Cc: Ye Ting <[email protected]> > > Cc: Fu Siyuan <[email protected]> > > Cc: Laszlo Ersek <[email protected]> > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Wu Jiaxin <[email protected]> > > --- > > NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > b/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > > index e2a0eb44b1..f2ec34df93 100644 > > --- a/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > > +++ b/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > > @@ -1,12 +1,17 @@ > > ## @file > > # Access PXE-compatible devices for network access and network booting. > > # > > # This driver provides PXE Base Code Protocol which is used to accessing > > -# PXE-compatible device for network access or booting. It could work > together > > -# with an IPv4 stack, an IPv6 stack or both. > > +# PXE-compatible device for network access or booting. This driver > supports > > +# both IPv4 and IPv6 network stack. > > # > > +# Notes: > > +# 1) This driver can't co-work with the UefiPxeBcDxe driver in > MdeModulePkg. > > +# 2) This driver includes more bugs fix and supports more features (e.g. > IPv6, > > +# MTFTP windowsize) than the UefiPxeBcDxe driver in MdeModulePkg. > So, we > > +# recommand to use this driver even both of them can be used. > > # > > # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR> > > # > > # This program and the accompanying materials > > # are licensed and made available under the terms and conditions of the > BSD License > > > > Same comments as for patch #4. With those updates: > > Reviewed-by: Laszlo Ersek <[email protected]> > > Thanks, > Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
