Hi Laszlo, > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of > Laszlo Ersek > Sent: Monday, October 08, 2018 7:55 PM > To: Bi, Dandan <[email protected]>; [email protected] > Cc: Ni, Ruiyu <[email protected]>; Kinney, Michael D > <[email protected]>; Gao, Liming <[email protected]> > Subject: Re: [edk2] [patch 1/5] MdePkg: Correct the string expression of > UTF8 vendor device path > > Hi Dandan, > > On 10/08/18 05:31, Dandan Bi wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1225 > > > > According to UEFI spec, the string expression of UTF8 vendor device > > node should be displayed as: VenUtf8(). Current code display it as: > > VenUft8() by mistake when convert device path node to text. > > > > This commit is to fix this bug. > > > > Cc: Ruiyu Ni <[email protected]> > > Cc: Michael D Kinney <[email protected]> > > Cc: Liming Gao <[email protected]> > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Dandan Bi <[email protected]> > > --- > > MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > > b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > > index 7d8d304f6f..85f5e97131 100644 > > --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > > +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > > @@ -193,11 +193,11 @@ DevPathToTextVendor ( > > return ; > > } else if (CompareGuid (&Vendor->Guid, &gEfiVT100PlusGuid)) { > > UefiDevicePathLibCatPrint (Str, L"VenVt100Plus()"); > > return ; > > } else if (CompareGuid (&Vendor->Guid, &gEfiVTUTF8Guid)) { > > - UefiDevicePathLibCatPrint (Str, L"VenUft8()"); > > + UefiDevicePathLibCatPrint (Str, L"VenUtf8()"); > > return ; > > } else if (CompareGuid (&Vendor->Guid, &gEfiUartDevicePathGuid)) { > > FlowControlMap = (((UART_FLOW_CONTROL_DEVICE_PATH *) > Vendor)->FlowControlMap); > > switch (FlowControlMap & 0x00000003) { > > case 0: > > > > it makes sense to send a set of patches that are correlated in some fashion, > even if they individually address different BZs and don't form a coherent > "feature" or larger "bugfix". However, even in such cases, please send a > common cover letter (0/5 in this case). Seeing a unified diffstat, and a few > intro words (about the common theme of the patch > set) is helpful. > > (no need to repost, just for the future) > Thanks for the reminder, I will pay more attention in the future.
Thanks, Dandan > Thanks > Laszlo > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
