Hi Dandan, On 10/08/18 05:31, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1225 > > According to UEFI spec, the string expression of UTF8 vendor > device node should be displayed as: VenUtf8(). Current code > display it as: VenUft8() by mistake when convert device > path node to text. > > This commit is to fix this bug. > > Cc: Ruiyu Ni <ruiyu...@intel.com> > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi <dandan...@intel.com> > --- > MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > index 7d8d304f6f..85f5e97131 100644 > --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > @@ -193,11 +193,11 @@ DevPathToTextVendor ( > return ; > } else if (CompareGuid (&Vendor->Guid, &gEfiVT100PlusGuid)) { > UefiDevicePathLibCatPrint (Str, L"VenVt100Plus()"); > return ; > } else if (CompareGuid (&Vendor->Guid, &gEfiVTUTF8Guid)) { > - UefiDevicePathLibCatPrint (Str, L"VenUft8()"); > + UefiDevicePathLibCatPrint (Str, L"VenUtf8()"); > return ; > } else if (CompareGuid (&Vendor->Guid, &gEfiUartDevicePathGuid)) { > FlowControlMap = (((UART_FLOW_CONTROL_DEVICE_PATH *) > Vendor)->FlowControlMap); > switch (FlowControlMap & 0x00000003) { > case 0: >
it makes sense to send a set of patches that are correlated in some fashion, even if they individually address different BZs and don't form a coherent "feature" or larger "bugfix". However, even in such cases, please send a common cover letter (0/5 in this case). Seeing a unified diffstat, and a few intro words (about the common theme of the patch set) is helpful. (no need to repost, just for the future) Thanks Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
