Thanks Brian, Long, could you please 1) Send me the commit hashes of micropython and oniguruma that you have tested with the overrides? 2) Add a top-level Readme.md to the MicroPythonTestFramework branch, mentioning yourself as maintainer and the commit hashes of any external projects used?
Best Regards, Leif On Fri, Oct 19, 2018 at 06:18:35AM +0000, Richardson, Brian wrote: > Leif: > > Thank you for your feedback. Long Qin is a good starting contact for > MicroPython issues. > > There are readme files for the sub-components, but I agree that the missing > top-level readme file is an issue. > https://github.com/tianocore/edk2-staging/tree/MicroPythonTestFramework/MpyTestFrameworkPkg > https://github.com/tianocore/edk2-staging/tree/MicroPythonTestFramework/MicroPythonPkg > > Thanks … br > --- > Brian Richardson, Firmware Ecosystem Development, Intel Software > brian.richard...@intel.com<mailto:brian.richard...@intel.com> -- @intel_brian > (Twitter & WeChat) > https://software.intel.com/en-us/meet-the-developers/evangelists/team/brian-richardson > > From: Leif Lindholm <leif.lindh...@linaro.org> > Sent: Friday, October 19, 2018 12:34 AM > To: Richardson, Brian <brian.richard...@intel.com> > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [staging/MicroPythonTestFramework]: MicroPython Test > Framework for UEFI > > Hi Brian, > > I've started having a look at this, and have a few comments: > - There is no Readme.md at the top level, as set out in > https://github.com/tianocore/edk2-staging/blob/about/README > Mainly, this means I don't know who I should cc on any comments I have. > - There have been substantial changes to oniguruma, and the module no longer > builds. Can we have exact commit hashes for the two external projects added > to the toplevel Readme.md? > - At least Uefi/modets.c and Uefi/modos.c contain Ia32/X64-specific bits. > Could these bits be put in architecture-specific subdirectories? > > Regards, > > Leif > > On 10 August 2018 at 03:44, Richardson, Brian > <brian.richard...@intel.com<mailto:brian.richard...@intel.com>> wrote: > The "MicroPython Test Framework for UEFI" project has been added to > edk2-staging for community feedback. > https://github.com/tianocore/edk2-staging/tree/MicroPythonTestFramework > > This includes a port of MicroPython to UEFI and a test execution environment > that can run from the UEFI Shell. > https://github.com/tianocore/edk2-staging/tree/MicroPythonTestFramework/MicroPythonPkg > https://github.com/tianocore/edk2-staging/tree/MicroPythonTestFramework/MpyTestFrameworkPkg > > Additional Info: > https://github.com/tianocore/tianocore.github.io/wiki/MicroPython-Test-Framework-for-UEFI > > Thanks ... br > --- > Brian Richardson, Senior Technical Marketing Engineer, Intel Software > brian.richard...@intel.com<mailto:brian.richard...@intel.com><mailto:brian.richard...@intel.com<mailto:brian.richard...@intel.com>> > -- @intel_brian (Twitter & WeChat) > https://software.intel.com/en-us/meet-the-developers/evangelists/team/brian-richardson > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
