(+PhilMD) On 11/02/18 04:23, yuchenlin via edk2-devel wrote: > From: yuchenlin <[email protected]> > > In this series, replace the original vmsvga driver to Bochs > interface. > > Simply revert vmsvga driver implementation. After it, use Bochs > interface for initializing vmsvga. > > Because of the PCI BARs difference between std vga and vmsvga. > We can not simply recognize the "QEMU VMWare SVGA" as the > QEMU_VIDEO_BOCHS_MMIO variant. > > BAR | std vga | vmsvga > --------------------------------- > 0 | Framebuffer | I/O space > 1 | Reserved | Framebuffer > 2 | MMIO | FIFO > > To overcome this problem, we remain variant QEMU_VIDEO_VMWARE_SVGA, > and use it for: > > (1) Get framebuffer from correct PCI BAR > (2) Prevent using BAR2 for MMIO > > We have tested on qemu before and after commit 104bd1dc70 and all > worked. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: yuchenlin <[email protected]> > > Changelog: > v1 -> v2 > * use 'else' clause (Thanks Philippe). > * add more comment in revert patches (Thanks Philippe). > * reorder the revert patches, we should revert the last commit first. > * use correct framebuffer to ClearScreen. > * revert VMWare svga definitions.
I'll have to ask for a bit more patience until I come to this series. I can process only so much email backlog in one day. :) And I don't want to butcher this review due to fatigue. Meanwhile, thank you both Phils for the v1 comments! Please comment on v2 as well, if you can! Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
