Reviewed-by: Jian J Wang <[email protected]>
> -----Original Message----- > From: Laszlo Ersek [mailto:[email protected]] > Sent: Thursday, January 03, 2019 10:48 AM > To: edk2-devel-01 <[email protected]> > Cc: Wei, Gang <[email protected]>; Wang, Jian J <[email protected]>; > Ye, Ting <[email protected]> > Subject: [PATCH 25/26] CryptoPkg/BaseCryptLib: drop build flags specific to > GCC44 > > We've removed BaseTools support for GCC44..GCC47. Drop > CryptoPkg/BaseCryptLib build flags that are specific to any of those gcc > versions. > > No GCC44..GCC47 references remain under CryptoPkg after this patch. > > Cc: Gang Wei <[email protected]> > Cc: Jian Wang <[email protected]> > Cc: Ting Ye <[email protected]> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1377 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek <[email protected]> > --- > > Notes: > Build tested with: > > ( > set -e > for INF in CryptoPkg/Library/BaseCryptLib/*.inf; do > build -t GCC48 -a IA32 -b DEBUG -p CryptoPkg/CryptoPkg.dsc \ > -m "$INF" > done > ) > > CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 2 -- > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 -- > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 2 -- > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 1 - > 4 files changed, 7 deletions(-) > > diff --git a/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > index f29445ce3402..0d81db2fbd7f 100644 > --- a/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > @@ -96,8 +96,6 @@ [BuildOptions] > # > MSFT:*_*_*_CC_FLAGS = /wd4090 > > - GCC:*_GCC44_IA32_CC_FLAGS = "-D__cdecl=__attribute__((cdecl))" "- > D__declspec(t)=__attribute__((t))" > - > # -JCryptoPkg/Include : To disable the use of the system includes provided > by > RVCT > # --diag_remark=1 : Reduce severity of "#1-D: last line of file ends > without a > newline" > RVCT:*_*_ARM_CC_FLAGS = -JCryptoPkg/Include --diag_remark=1 > diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > index e7b4b2f61855..4bcf064c5623 100644 > --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > @@ -93,8 +93,6 @@ [BuildOptions] > # > MSFT:*_*_*_CC_FLAGS = /wd4090 /wd4718 > > - GCC:*_GCC44_IA32_CC_FLAGS = "-D__cdecl=__attribute__((cdecl))" "- > D__declspec(t)=__attribute__((t))" > - > # -JCryptoPkg/Include : To disable the use of the system includes provided > by > RVCT > # --diag_remark=1 : Reduce severity of "#1-D: last line of file ends > without a > newline" > RVCT:*_*_ARM_CC_FLAGS = -JCryptoPkg/Include --diag_remark=1 > diff --git a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > index 32628c8835a6..a6e433f6ced1 100644 > --- a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > @@ -102,8 +102,6 @@ [BuildOptions] > # > MSFT:*_*_*_CC_FLAGS = /wd4090 > > - GCC:*_GCC44_IA32_CC_FLAGS = "-D__cdecl=__attribute__((cdecl))" "- > D__declspec(t)=__attribute__((t))" > - > # -JCryptoPkg/Include : To disable the use of the system includes provided > by > RVCT > # --diag_remark=1 : Reduce severity of "#1-D: last line of file ends > without a > newline" > RVCT:*_*_ARM_CC_FLAGS = -JCryptoPkg/Include --diag_remark=1 > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > index 4829669c1f3f..c34699cd62bf 100644 > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > @@ -100,5 +100,4 @@ [BuildOptions] > # > MSFT:*_*_*_CC_FLAGS = /wd4090 > > - GCC:*_GCC44_IA32_CC_FLAGS = "-D__cdecl=__attribute__((cdecl))" "- > D__declspec(t)=__attribute__((t))" > XCODE:*_*_*_CC_FLAGS = -mmmx -msse > -- > 2.19.1.3.g30247aa5d201 > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
