On 01/07/19 13:15, Gao, Liming wrote: > Laszlo: > This patch set is good to me. Reviewed-by: Liming Gao <[email protected]>
Many thanks to everyone for the quick reviews! > Besides this patch set, I suggest to let GCC48/GCC49/GCC5 refer to the > common GCC_ flags. After I remove ELFGCC/UNIXGCC/CYGGCC tool chain, I will > update GCC_ flags to be same to current GCC48_ flags, then remove GCC48_ flag > definition. Sounds good to me, thanks. IIRC I actually looked into calling that stuff just GCC_, but I seem to remember that the subject macros were already defined for other purposes. Once you eliminate ELFGCC/UNIXGCC/CYGGCC, hopefully all those macros can be collapsed. For this series, I plan to go through the feedback tags in detail, shortly, and push the series if everything is sufficiently approved. Thanks! Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
