One minor comment.

With it handled, Reviewed-by: Star Zeng <[email protected]>

On 2019/1/14 21:27, Ard Biesheuvel wrote:
Reuse most of the existing code to implement a variable runtime
driver that will be able to execute in the context of standalone
MM.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <[email protected]>
Reviewed-by: Jian J Wang <[email protected]>
Reviewed-by: Star Zeng <[email protected]>
---
  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf | 136 
++++++++++++++++++++
  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c   |  89 
+++++++++++++
  2 files changed, 225 insertions(+)


[Trimmed]

+
+/**
+  Variable service MM driver entry point

The comments block should have description for the two parameters and return status (forgot to mention this for other places).


Thanks,
Star

+**/
+EFI_STATUS
+EFIAPI
+VariableServiceInitialize (
+  IN EFI_HANDLE                           ImageHandle,
+  IN EFI_MM_SYSTEM_TABLE                  *MmSystemTable
+  )
+{
+  return MmVariableServiceInitialize ();
+}
+
+/**
+  Whether the TCG or TCG2 protocols are installed in the UEFI protocol 
database.
+  This information is used by the MorLock code to infer whether an existing
+  MOR variable is legitimate or not.
+
+  @retval TRUE  Either the TCG or TCG2 protocol is installed in the UEFI
+                protocol database
+  @retval FALSE Neither the TCG nor the TCG2 protocol is installed in the UEFI
+                protocol database
+**/
+BOOLEAN
+VariableHaveTcgProtocols (
+  VOID
+  )
+{
+  return FALSE;
+}


_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to