David, I think we got an agreement here to move CSM components in OvmfPkg. I prefer we firstly clone the required CSM components in OvmfPkg right no. Finally I can remove the IntelFrameworkModulePkg/IntelFrameworkPkg in one patch. (I say "finally" because OVMF CSM dependency is not the only case that prevent removing the two framework packages.)
Would you like to do the clone? Or if you are busy, I can do that. Thanks, Ray > -----Original Message----- > From: David Woodhouse [mailto:dw...@infradead.org] > Sent: Wednesday, January 23, 2019 5:49 PM > To: Laszlo Ersek <ler...@redhat.com>; Ni, Ray <ray...@intel.com>; Gerd > Hoffmann <kra...@redhat.com>; Richardson, Brian > <brian.richard...@intel.com> > Cc: Justen, Jordan L <jordan.l.jus...@intel.com>; edk2-devel@lists.01.org; > Kevin O'Connor <ke...@koconnor.net>; Anthony Perard > <anthony.per...@citrix.com> > Subject: Re: Drop CSM support in OvmfPkg? > > On Wed, 2019-01-23 at 10:46 +0100, Laszlo Ersek wrote: > > I'm fine if we move the generic CSM components into OvmfPkg, however I'm > > going to ask David to assume reviewer responsibilities for them. > > > > Given the current format of "Maintainers.txt", we couldn't spell out the > > exact pathnames of the CSM components, so we'd add a line like > > > > R: David Woodhouse <dw...@infradead.org> > > > > under OvmfPkg. There is "prior art" for this pattern, see: > > > > R: Anthony Perard <anthony.per...@citrix.com> > > R: Julien Grall <julien.gr...@linaro.org> > > > > Because Anthony and Julien are the authority on Xen-related code under > > OvmfPkg. (See commit 337fe6a06eda, "Maintainers.txt: add Xen reviewers > > to OvmfPkg", 2017-09-26.) > > > > > > If we keep CSM support in OvmfPkg in any form at all, then I would > > prefer holding all the related stuff in the core edk2 repository (with > > the above Reviewership), over requiring people to deal with multiple > > repositories. I agree (from experience) that PACKAGES_PATH / multiple > > workspaces work fine, but in this case I think keeping one shared > > history is an advantage. > > This all makes sense to me. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
