Hi Antoine, On 2/7/19 6:13 PM, Antoine Coeur wrote: > Thank you Laszlo. > > Do you have any recommendations regarding the maximum size of a patch for > smooth reviewing on this mailing list? > I have about 9000 lines of additional typos corrections in queue at > https://github.com/Coeur/edk2/tree/typo, but I'm afraid that big patches will > simply be ignored.
I tagged your "BaseTools: Fix various typos" patch for review, but it is true than after reading the diff stats "172 files changed, 513 insertions(+), 518 deletions(-)" I procrastinated and skipped to the next patch to review... The rule of thumb I learned is the limit to the magic number 20, probably related to our number of fingers/toes :P For example you could split the previous patch in: BaseTools/Source/C/Common BaseTools/Source/C/VfrCompile BaseTools/Source/C/* (other) BaseTools/Source/Python And it would be more digest. > If I split them in small patches, how many patches can I post every day? Or > should I post a hundred patches at the same time and reviewers won't freak > out? The list shouldn't have limition in how many patches you can send, the bottleneck here is the human brain and how many patches a reviewer can take. Since your patches are related (all fixes typos), what would help is if you group your patches in series, instead of sending separately. Same here, I recommend the 20 limit. For example you can send various series of up-to 20 patches, like: - Board X + Y - Board Z - Package X - Module Y - Arm - Intel > Or could we exceptionally allow pull requests on GitHub for those typos > changes, as it doesn't involve actual code-change? That could be an > interesting experiment that would prevent cluttering the mailing-list. There is a study in progress to use another workflow than mailing list, but we are not there yet. Anyway, don't worry about stressing the mailing list ;) Regards, Phil. > > Coeur > > > > Gesendet: Donnerstag, 07. Februar 2019 um 21:33 Uhr > Von: "Laszlo Ersek" <[email protected]> > An: "Antoine Coeur" <[email protected]>, [email protected] > Betreff: Re: [edk2] [PATCH v2] ArmVirtPkg: Fix various typos > > Pushed as commit 7a90895306ac. > > Thanks, > Laszlo > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
