On Fri, Feb 01, 2019 at 09:34:21PM +0800, Ming Huang wrote: > SerdesLib is useless for SmbiosMiscDxe and D06, so remove it.
Should it not then also delete #include <Library/SerdesLib.h> from Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c, Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c and Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotDesignationFunction.c ? Meanwhile, Platform/Hisilicon/D03/Library/OemMiscLib2P/BoardFeature2PHi1610.c and Platform/Hisilicon/D05/Library/OemMiscLibD05/BoardFeatureD05.c both include this header, but Platform/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.inf and Platform/Hisilicon/D05/Library/OemMiscLibD05/OemMiscLibD05.inf do not declare the dependency. Can you investigate and submit an updated patch addressing all of the unnecessary references? Best Regards, Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang <ming.hu...@linaro.org> > --- > Platform/Hisilicon/D06/D06.dsc | 2 -- > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 1 - > 2 files changed, 3 deletions(-) > > diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc > index 396bd03c9d24..cbbd99e4a659 100644 > --- a/Platform/Hisilicon/D06/D06.dsc > +++ b/Platform/Hisilicon/D06/D06.dsc > @@ -64,8 +64,6 @@ [LibraryClasses.common] > > CpldIoLib|Silicon/Hisilicon/Library/CpldIoLib/CpldIoLib.inf > > - SerdesLib|Silicon/Hisilicon/Hi1620/Library/Hi1620Serdes/Hi1620SerdesLib.inf > - > TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf > > RealTimeClockLib|Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.inf > OemMiscLib|Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf > diff --git a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > index 61cead7779b9..8e5c56fa41fd 100644 > --- a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > +++ b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > @@ -77,7 +77,6 @@ [LibraryClasses] > > IpmiCmdLib > > - SerdesLib > > [Protocols] > gEfiSmbiosProtocolGuid # PROTOCOL ALWAYS_CONSUMED > -- > 2.9.5 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
