Zhichao: My comment is to change function name as RuntimeServiceResetSystem. This is the similar name in RuntimeServiceSetVariable of Variable driver. I don't suggest to use Efi as function prefix.
Thanks Liming > -----Original Message----- > From: Gao, Zhichao > Sent: Wednesday, February 20, 2019 4:39 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ray <ray...@intel.com>; Gao, Liming <liming....@intel.com> > Subject: [PATCH v3 1/6] MdeModulePkg: change the function name ResetSystem > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 > > Change the function name form ResetSystem to EfiRuntimeResetSystem. > Because ResetSystem and EfiResetSystem would be used in ResetSystemLib > and RuntimeLib. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhichao Gao <zhichao....@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Liming Gao <liming....@intel.com> > --- > MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c | 8 ++++---- > MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > index afc35587fc..e16b0cda7b 100644 > --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > +++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > @@ -1,7 +1,7 @@ > /** @file > Reset Architectural and Reset Notification protocols implementation. > > - Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR> > + Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR> > > This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD > License > @@ -187,7 +187,7 @@ InitializeResetSystem ( > // > // Hook the runtime service table > // > - gRT->ResetSystem = ResetSystem; > + gRT->ResetSystem = EfiRuntimeResetSystem; > > // > // Now install the Reset RT AP on a new handle > @@ -242,7 +242,7 @@ DoS3 ( > **/ > VOID > EFIAPI > -ResetSystem ( > +EfiRuntimeResetSystem ( > IN EFI_RESET_TYPE ResetType, > IN EFI_STATUS ResetStatus, > IN UINTN DataSize, > @@ -256,7 +256,7 @@ ResetSystem ( > RESET_NOTIFY_ENTRY *Entry; > > // > - // Only do REPORT_STATUS_CODE() on first call to ResetSystem() > + // Only do REPORT_STATUS_CODE() on first call to EfiRuntimeResetSystem() > // > if (mResetNotifyDepth == 0) { > // > diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h > b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h > index 8529de675c..448e30f079 100644 > --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h > +++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h > @@ -1,6 +1,6 @@ > /** @file > > - Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR> > + Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR> > > This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD > License > @@ -97,7 +97,7 @@ InitializeResetSystem ( > **/ > VOID > EFIAPI > -ResetSystem ( > +EfiRuntimeResetSystem ( > IN EFI_RESET_TYPE ResetType, > IN EFI_STATUS ResetStatus, > IN UINTN DataSize, > -- > 2.16.2.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
