Zhichao: For patch2~5, my comment is to move patch 4 as patch 2. Normally, we add API definition in library class header file first, then update the library instance implementation. I have no comments for the code change. Reviewed-by: Liming Gao <liming....@intel.com>
Thanks Liming > -----Original Message----- > From: Gao, Zhichao > Sent: Wednesday, February 20, 2019 4:39 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ray <ray...@intel.com>; Gao, Liming <liming....@intel.com> > Subject: [PATCH v3 0/6] ResetSystemLib changings > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 > Add a new API ResetSystem in ResetSystemLib. > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1461 > Implement a runtime library instance of ResetSystemLib base on the new > changing. > > V2: Add some required data type header file > > V3: Resolve a case-typing error. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhichao Gao <zhichao....@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Liming Gao <liming....@intel.com> > > Zhichao Gao (6): > MdeModulePkg: change the function name ResetSystem > MdeModulePkg: Add a new API ResetSystem for DXE ResetSystemLib > MdeModulePkg: Add a new API ResetSystem for Null version > MdeModulePkg: Add the new API ResetSystem in the head file > MdeModulePkg: Add a runtime library instance of ResetSystemLib > MdeModulePkg: Add the runtime ResetSystemLib in MdeModulePkg.dsc > > MdeModulePkg/Include/Library/ResetSystemLib.h | 28 ++- > .../BaseResetSystemLibNull.c | 27 +++ > .../Library/DxeResetSystemLib/DxeResetSystemLib.c | 28 ++- > .../RuntimeResetSystemLib/RuntimeResetSystemLib.c | 216 > +++++++++++++++++++++ > .../RuntimeResetSystemLib.inf | 50 +++++ > .../RuntimeResetSystemLib.uni | 21 ++ > MdeModulePkg/MdeModulePkg.dsc | 1 + > .../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 8 +- > .../Universal/ResetSystemRuntimeDxe/ResetSystem.h | 4 +- > 9 files changed, 375 insertions(+), 8 deletions(-) > create mode 100644 > MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.c > create mode 100644 > MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.inf > create mode 100644 > MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.uni > > -- > 2.16.2.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
