On 02/26/19 04:30, Gao, Liming wrote: > Hi, all > Two features (Add SMM CET support and Add WiFi Connection Manager) get > Acked-By or Reviewed-by near the soft feature freeze date. CET is X86 > specific feature. WiFi connection manager is the standalone feature. Their > impact should be small. So, I suggest to include them in this stable tag > edk2-stable201903. If you have different opinion, please raise. If no > objection, I will push them late this week. > > Add SMM CET support > https://lists.01.org/pipermail/edk2-devel/2019-February/037128.html > NetworkPkg: Add WiFi Connection Manager to NetworkPkg > https://lists.01.org/pipermail/edk2-devel/2019-February/037137.html
I think the required feedback tags arrived on time, but just barely. (At least in my time zone, CET = UTC+01:00.) - For Jiewen's "[edk2] [PATCH V3 0/4] Add SMM CET support": - Ray's R-b appeared at 02/22/19 15:29 - My Regression-tested-by appeared at 02/22/19 22:41 - For Wang Fan's "[edk2] [Patch V2] NetworkPkg: Add WiFi Connection Manager to NetworkPkg": - Jiaxin's R-b appeared at 02/22/19 08:56. I'm OK if both features are pushed. However, I do have a suggestion for the announcement email, for the future. Given that we've already encountered three cases in this cycle where the feedback tags are on the boundary, I suggest to include an exact timestamp (in the UTC zone) in each announcement. I never expected that this accuracy would be necessary, but apparently it is. Thanks! Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel