Reviewed-by: Ray Ni <ray...@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Friday, March 29, 2019 9:41 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ray <ray...@intel.com>
> Subject: [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib
> 
> With Itanium architecture unsupported, gEfiSalSystemTableGuid and
> gEfiMpsTableGuid will be no longer used.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1560
> 
> Cc: Jaben Carsey <jaben.car...@intel.com>
> Cc: Ray Ni <ray...@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com>
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c     | 10 ----------
>  .../UefiShellDebug1CommandsLib.inf                     |  2 --
>  2 files changed, 12 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> index a4c18c9b68..023806742d 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> @@ -17,9 +17,7 @@
>  #include "UefiShellDebug1CommandsLib.h"
>  #include <Protocol/PciRootBridgeIo.h>
>  #include <Guid/Acpi.h>
> -#include <Guid/Mps.h>
>  #include <Guid/SmBios.h>
> -#include <Guid/SalSystemTable.h>
> 
>  /**
>    Make a printable character.
> @@ -186,10 +184,6 @@ ShellCommandRunDmem (
>                AcpiTableAddress = (UINT64)(UINTN)gST-
> >ConfigurationTable[TableWalker].VendorTable;
>                continue;
>              }
> -            if (CompareGuid(&gST->ConfigurationTable[TableWalker].VendorGuid,
> &gEfiSalSystemTableGuid)) {
> -              SalTableAddress = (UINT64)(UINTN)gST-
> >ConfigurationTable[TableWalker].VendorTable;
> -              continue;
> -            }
>              if (CompareGuid(&gST->ConfigurationTable[TableWalker].VendorGuid,
> &gEfiSmbiosTableGuid)) {
>                SmbiosTableAddress = (UINT64)(UINTN)gST-
> >ConfigurationTable[TableWalker].VendorTable;
>                continue;
> @@ -198,10 +192,6 @@ ShellCommandRunDmem (
>                SmbiosTableAddress = (UINT64) (UINTN) gST-
> >ConfigurationTable[TableWalker].VendorTable;
>                continue;
>              }
> -            if (CompareGuid(&gST->ConfigurationTable[TableWalker].VendorGuid,
> &gEfiMpsTableGuid)) {
> -              MpsTableAddress = (UINT64)(UINTN)gST-
> >ConfigurationTable[TableWalker].VendorTable;
> -              continue;
> -            }
>            }
> 
>            ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_DMEM_SYSTEM_TABLE),
> gShellDebug1HiiHandle, diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi
> b.inf
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi
> b.inf
> index ec1f87ae19..f2666b7ff9 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi
> b.inf
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Command
> +++ sLib.inf
> @@ -130,8 +130,6 @@
>    gEfiGlobalVariableGuid          ## SOMETIMES_CONSUMES ## GUID
>    gEfiSmbiosTableGuid             ## SOMETIMES_CONSUMES ## SystemTable
>    gEfiSmbios3TableGuid            ## SOMETIMES_CONSUMES ## SystemTable
> -  gEfiMpsTableGuid                ## SOMETIMES_CONSUMES ## SystemTable
> -  gEfiSalSystemTableGuid          ## SOMETIMES_CONSUMES ## SystemTable
>    gEfiAcpi10TableGuid             ## SOMETIMES_CONSUMES ## SystemTable
>    gEfiAcpi20TableGuid             ## SOMETIMES_CONSUMES ## SystemTable
>    gShellDebug1HiiGuid             ## SOMETIMES_CONSUMES ## HII
> --
> 2.18.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to