Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -----Original Message----- > From: Ni, Ray > Sent: Thursday, March 28, 2019 6:50 PM > To: Zhang, Shenglei <shenglei.zh...@intel.com>; edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com> > Subject: RE: [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some > unused Guids > Importance: High > > Reviewed-by: Ray Ni <ray...@intel.com> > > > -----Original Message----- > > From: Zhang, Shenglei > > Sent: Friday, March 29, 2019 9:41 AM > > To: edk2-devel@lists.01.org > > Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ray <ray...@intel.com> > > Subject: [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused > > Guids > > > > ExtendedSalBootService.h, ExtendedSalServiceClasses.h and McaInitPmi.h > > will be deleted. So remove the Guids defined in these Protocols. And > > also remove strings in uni file. > > https://bugzilla.tianocore.org/show_bug.cgi?id=1560 > > > > Cc: Jaben Carsey <jaben.car...@intel.com> > > Cc: Ray Ni <ray...@intel.com> > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com> > > --- > > .../UefiHandleParsingLib/UefiHandleParsingLib.c | 17 ----------------- > > .../UefiHandleParsingLib.inf | 17 ----------------- > > .../UefiHandleParsingLib.uni | 17 ----------------- > > 3 files changed, 51 deletions(-) > > > > diff --git > > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > index 2d94a52108..a106c0906c 100644 > > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > @@ -2321,23 +2321,6 @@ STATIC CONST GUID_INFO_BLOCK > mGuidStringList[] > > = { > > {STRING_TOKEN(STR_FVB2), > > &gEfiFirmwareVolumeBlock2ProtocolGuid, NULL}, > > {STRING_TOKEN(STR_CPUIO2), &gEfiCpuIo2ProtocolGuid, > > NULL}, > > {STRING_TOKEN(STR_LEGACY_R2), > &gEfiLegacyRegion2ProtocolGuid, > > NULL}, > > - {STRING_TOKEN(STR_SAL_MIP), &gEfiSalMcaInitPmiProtocolGuid, > > NULL}, > > - {STRING_TOKEN(STR_ES_BS), > > &gEfiExtendedSalBootServiceProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_BIO), > > &gEfiExtendedSalBaseIoServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_STALL), > > &gEfiExtendedSalStallServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_RTC), > > &gEfiExtendedSalRtcServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_VS), > > &gEfiExtendedSalVariableServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_MTC), > > &gEfiExtendedSalMtcServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_RESET), > > &gEfiExtendedSalResetServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_SC), > > &gEfiExtendedSalStatusCodeServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_FBS), > > &gEfiExtendedSalFvBlockServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_MP), > > &gEfiExtendedSalMpServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_PAL), > > &gEfiExtendedSalPalServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_BASE), > > &gEfiExtendedSalBaseServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_MCA), > > &gEfiExtendedSalMcaServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_PCI), > > &gEfiExtendedSalPciServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_CACHE), > > &gEfiExtendedSalCacheServicesProtocolGuid, NULL}, > > - {STRING_TOKEN(STR_ES_MCA_LOG), > > &gEfiExtendedSalMcaLogServicesProtocolGuid, NULL}, > > {STRING_TOKEN(STR_S2ARCH), &gEfiSecurity2ArchProtocolGuid, > > NULL}, > > {STRING_TOKEN(STR_EODXE), &gEfiSmmEndOfDxeProtocolGuid, > > NULL}, > > {STRING_TOKEN(STR_ISAHC), &gEfiIsaHcProtocolGuid, > > NULL}, > > diff --git > > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > index a795fb92de..edab57f892 100644 > > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > @@ -234,23 +234,6 @@ > > gEfiFirmwareVolumeBlock2ProtocolGuid ## UNDEFINED > > gEfiCpuIo2ProtocolGuid ## UNDEFINED > > gEfiLegacyRegion2ProtocolGuid ## UNDEFINED > > - gEfiSalMcaInitPmiProtocolGuid ## UNDEFINED > > - gEfiExtendedSalBootServiceProtocolGuid ## UNDEFINED > > - gEfiExtendedSalBaseIoServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalStallServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalRtcServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalVariableServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalMtcServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalResetServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalStatusCodeServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalFvBlockServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalMpServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalPalServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalBaseServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalMcaServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalPciServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalCacheServicesProtocolGuid ## UNDEFINED > > - gEfiExtendedSalMcaLogServicesProtocolGuid ## UNDEFINED > > gEfiSecurity2ArchProtocolGuid ## UNDEFINED > > gEfiSmmEndOfDxeProtocolGuid ## UNDEFINED > > gEfiIsaHcProtocolGuid ## UNDEFINED > > diff --git > > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > index 15f3912045..3238441b1e 100644 > > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > @@ -274,23 +274,6 @@ > > #string STR_FVB2 #language en-US "FirmwareVolumeBlock2" > > #string STR_CPUIO2 #language en-US "CpuIo2" > > #string STR_LEGACY_R2 #language en-US "LegacyRegion2" > > -#string STR_SAL_MIP #language en-US "SalMcaInitPmi" > > -#string STR_ES_BS #language en-US "ExtendedSalBootService" > > -#string STR_ES_BIO #language en-US > > "ExtendedSalBaseIoServices" > > -#string STR_ES_STALL #language en-US > > "ExtendedSalStallServices" > > -#string STR_ES_RTC #language en-US "ExtendedSalRtcServices" > > -#string STR_ES_VS #language en-US > "ExtendedSalVariableServices" > > -#string STR_ES_MTC #language en-US "ExtendedSalMtcServices" > > -#string STR_ES_RESET #language en-US > > "ExtendedSalResetServices" > > -#string STR_ES_SC #language en-US > "ExtendedSalStatusCodeServices" > > -#string STR_ES_FBS #language en-US > "ExtendedSalFvBlockServices" > > -#string STR_ES_MP #language en-US "ExtendedSalMpServices" > > -#string STR_ES_PAL #language en-US "ExtendedSalPalServices" > > -#string STR_ES_BASE #language en-US "ExtendedSalBaseServices" > > -#string STR_ES_MCA #language en-US "ExtendedSalMcaServices" > > -#string STR_ES_PCI #language en-US "ExtendedSalPciServices" > > -#string STR_ES_CACHE #language en-US > "ExtendedSalCacheServices" > > -#string STR_ES_MCA_LOG #language en-US > > "ExtendedSalMcaLogServices" > > #string STR_S2ARCH #language en-US "Security2Arch" > > #string STR_EODXE #language en-US "SmmEndOfDxe" > > #string STR_ISAHC #language en-US "IsaHc" > > -- > > 2.18.0.windows.1
_______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
