On 07/25/12 11:54, Laszlo Ersek wrote: > On 07/11/12 02:30, Jordan Justen wrote: >> On Tue, Jul 10, 2012 at 7:36 AM, Laszlo Ersek <ler...@redhat.com> wrote: > >>> + // >>> + // Send the print string to the debug I/O port >>> + // >>> + for (p = (UINT8 *) Buffer; *p; p++) { >>> + IoWrite8 (PcdGet16(PcdDebugIOPort), *p); >>> + } >>> +} >> >> Would IoWriteFifo8 help performance like it does for block devices on KVM? >> PcAtChipsetPkg/PciHostBridgeDxe/X64/IoFifo.S > > Should we try to call it (and add only a prototype)? > > Or should we add (copy) the imlementation too, like in > OvmfPkg/Library/QemuFwCfgLib/{Ia32,X64}?
On a second thought, the loop looks for the terminating NUL anyway. Is the performance gain worth the addition of four assembly files? It's a debug printf. Thanks, Laszlo ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel