Ray,
You recently added a new EDK Shell binary based on r59. Should I consider
this revision of EDK Shell as stable for your tested architectures ?
If yes, I can base my patches on this revision and send a new patchset to
replace EdkShellPkg\ShellR33.patch (by EdkShellPkg\ShellR59.patch) in EDK2.
I would like in a short term provide a pre-built binary of EdkShell (and
FatPkg/ShellPkg) such as it already exists for x86 architectures.
Regards,
Olivier
From: Andrew Fish [mailto:[email protected]]
Sent: 19 June 2012 16:29
To: Ni, Ruiyu
Cc: Olivier Martin; Krau, Michael P; [email protected]
Subject: Re: [PATCH] EdkShellPkg: Fixed case in filenames
At the time there was a snapshot of the shell available as a Zip file, and
in source control. I seem to remember there was not a processes for 3rd
party (non-Intel) contributions to EDK code. So the easiest thing to do to
make progress was to publish a patch.
Long term the plan was to move folks to the new pure edk2 ShellPkg, that did
not exist at the time of the port. I thought the EDK shell was dead and not
being maintained anymore?
Andrew Fish
On Jun 19, 2012, at 4:55 AM, Ni, Ruiyu wrote:
Actually I have a question why we created a ShellR33.patch in EdkShellPkg
instead of applying the patch to Shell source code directly years ago.
Is it because we don't want to change lots of Shell code and avoid doing a
stress Shell functionality test again?
Personally I agree any changes that don't affect the final Shell release
binary.
I guess 001, 003, 006, 008 should not affect the binary content. 005 should
be safe. But I am not sure whether 007 is safe because it changed a data
type from INTN to UINTN.
From: Olivier Martin [mailto:[email protected]]
Sent: Tuesday, June 19, 2012 5:34 PM
To: Olivier Martin; Ni, Ruiyu; 'Andrew Fish'; Krau, Michael P
Cc: [email protected]
Subject: RE: [PATCH] EdkShellPkg: Fixed case in filenames
Actually, some of the 'GCC' fixes are not GCC specific. There are just there
because the compiler (and its options) you are using to build efi-shell is
more permissive than GCC. That is not necessary a good news for you as you
could miss some bugs.
I think some of the 'GCC' patches could be pushed in efi-shell to improve
its code quality without breaking your development environment.
I have attached some of the patches I would like to contribute to the Gcc
Shell project.
From: Olivier Martin [mailto:[email protected]]
Sent: 18 June 2012 20:54
To: 'Ni, Ruiyu'; 'Andrew Fish'; 'Krau, Michael P'
Cc: [email protected]
Subject: RE: [PATCH] EdkShellPkg: Fixed case in filenames
I confirm I was applying the patch to Shell rev33.
Andrew, Michael> I have created a new patch set for the latest revision of
EFI Shell (rev61 - 18/06/2012) to be built by GCC. Today, GccShell supports
EFI Shell rev34 (14/09/2009). What should be the process to submit this
patch set in GCC Shell project ?
FYI, I have write access to the repository. I could potentially create a
branch.
Regards,
Olivier
From: Ni, Ruiyu [mailto:[email protected]]
Sent: 15 June 2012 06:00
To: Olivier Martin
Cc: [email protected]
Subject: RE: [PATCH] EdkShellPkg: Fixed case in filenames
Thanks for the explanation and the fix to the original ShellR33.patch.
Another thing I just think up is the patch file is based on the Shell
revision 33. Was your build test performed in Shell r33? If not you may need
to correct the Readme.txt and the patch file name to reflect your tested
revision.
Thanks,
Ray
From: Olivier Martin [mailto:[email protected]]
Sent: Thursday, June 14, 2012 11:27 PM
To: Ni, Ruiyu
Cc: [email protected]
Subject: RE: [PATCH] EdkShellPkg: Fixed case in filenames
Actually, I should have tested the new patch before committing it ...
Changing 'Ia32' into 'IA32' also breaks the build. The reason is the
original ShellR33.patch was doing this kind of changes:
diff --ignore-file-name-case -Naur ShellR33/Library/Ia32/EfiLibPlat.h
GccShellR33/Library/Ia32/EfiLibPlat.h
After applying the patch, the 'IA32' directory was renamed into 'Ia32' !
Please, find the new attached patch that replaces all the 'Ia32' of the
ShellR33.patch into 'IA32'.
I tested this patch and I confirm it fixes the build.
Olivier
From: Ni, Ruiyu [mailto:[email protected]]
Sent: 14 June 2012 02:13
To: Olivier Martin
Cc: [email protected]
Subject: RE: [PATCH] EdkShellPkg: Fixed case in filenames
Or you can check in directly with the fixed "IA32"J
From: Olivier Martin [mailto:[email protected]]
Sent: Thursday, June 14, 2012 4:24 AM
To: Ni, Ruiyu
Cc: [email protected]
Subject: RE: [PATCH] EdkShellPkg: Fixed case in filenames
Ray, are you expected a new patch with the fixed 'IA32' ?
From: Ni, Ruiyu [mailto:[email protected]]
Sent: 13 June 2012 16:37
To: Olivier Martin
Cc: [email protected]
Subject: RE: [PATCH] EdkShellPkg: Fixed case in filenames
Yes. I think the other parts of your patch is good. My only concern is your
patch uses "Ia32" but actually should be "IA32".
From: Olivier Martin [mailto:[email protected]]
Sent: Wednesday, June 13, 2012 11:34 PM
To: Ni, Ruiyu
Cc: [email protected]
Subject: RE: [PATCH] EdkShellPkg: Fixed case in filenames
You should have a look to efi-shell revision 33. But you are right, the
folder is 'IA32' and not 'Ia32'.
But the patch should still be considered as Library/EfiShellLib.inf refers
to 'ia32' and 'ipf' (instead of 'IA32' and 'IPF').
From: Ni, Ruiyu [mailto:[email protected]]
Sent: 13 June 2012 16:01
To: Olivier Martin
Cc: [email protected]
Subject: RE: [PATCH] EdkShellPkg: Fixed case in filenames
Olivier,
Is the folder "IA32" or "Ia32"? I see "IA32" in my browser.
<image001.jpg>
Thanks,
Ray
-----Original Message-----
From: Olivier Martin [mailto:[email protected]]
Sent: Wednesday, June 13, 2012 5:50 PM
To: Ni, Ruiyu
Cc: [email protected]
Subject: [PATCH] EdkShellPkg: Fixed case in filenames
Dear EdkShellPkg maintainer,
Please find the attached patch to fix the case of some filenames in
ShellR33.patch. These case issues break the builds on Unix system.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin < <mailto:[email protected]>
[email protected]>
Best Regards,
Olivier
<0001-Fixed-Unix-filename-paths.patch><0003-Fixed-GCC-warnings.patch><0005-F
ixed-Symbol-multiply-defined-RVCT-errors.patch><0006-ShellFull.inf-Renamed-n
ame-of-the-Full-Shell-was-She.patch><0007-Warning-pointer-targets-in-assignm
ent-differ-in-sign.patch><0008-Warning-passing-argument-from-incompatible-po
inter-t.patch>
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
