Hi:
Thanks for reporting this issue. I am working on it and give
fix to you to verify soon. By the way, do you use Visual Studio 2012 to build
BIOS?
Thanks
Elvin
From: Sergey Isakov [mailto:isakov...@bk.ru]
Sent: Sunday, October 07, 2012 6:03 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] ConSplitterDxe error in pointers
Dear sirs,
There are errors in
--------------------
edk2\MdeModulePkg\Universal\Console\consplitterdxe\consplitter.c(2181) :
warning C6305: Potential mismatch between sizeof and countof quantities. Use
sizeof() to scale byte sizes.: Lines: 2130, 2131, 2132, 2133, 2134, 2135, 2136,
2138, 2139, 2140, 2145, 2146, 2150, 2151, 2169, 2171, 2172, 2173, 2178, 2179,
2180, 2181
---------------------
This is not an warning, this is a serious bug.
---------------
INT32 *TextOutModeMap;
INT32 *OldTextOutModeMap;
INT32 *SrcAddress;
//
while (Index < Private->TextOutMode.MaxMode) {
CopyMem (TextOutModeMap, SrcAddress, Size);
TextOutModeMap += NewSize;
SrcAddress += Size;
Index++;
}
//
-----------------
For pointers operation +=count will change the value by count*sizeof(type)
So this must be corrected to
---------------
INT32 *TextOutModeMap;
INT32 *OldTextOutModeMap;
INT32 *SrcAddress;
//
while (Index < Private->TextOutMode.MaxMode) {
CopyMem (TextOutModeMap, SrcAddress, Size);
TextOutModeMap += NewSize / sizeof(INT32);
SrcAddress += Size / sizeof(INT32);
Index++;
}
//
-----------------
Sergey
------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
