On 10/08/12 09:42, Jordan Justen wrote: > Thanks Laszlo. Committed in r13801. > > Two requests for your next virtio series: > 1. Add inclusion guards in VirtioBlkDxe/*.h
Regarding headers. I have a working virtio-scsi driver now (no nice comments yet), but I have some parts that are shared by virtio-blk and virtio-scsi. You mentioned "OvmfPkg/Include/IndustryStandard" as a new directory to host the type and macro definitions, but I also have some functions to extract. Where should I put the header file with the function declarations, and the C file with the function definitions? > 2. Make OFFSET_OF_VHDR use OFFSET_OF Ugh. For some reason I was convinced that OFFSET_OF didn't exist yet. It's not that I forgot to search for it, I searched and decided it wasn't there. Strange. > I noticed the -drive file=cd.iso,if=virtio doesn't seem to boot the > ISO. This does work for seabios. I wonder if this is luck based on the > ISO layout, or if seabios detects this. I have not tested this scenario. I tried it now (from virt-manager, as usual), but "Advanced Options | Disk bus" for CD-ROMs only allows two values, IDE and SCSI. Virtio is not listed. > Perhaps SCSI based virtio will detect it as a CD/DVD, and work correctly? I tested that now. OVMF boots grub2 from the Fedora-18-Alpha-x86_64-Live-XFCE.iso virtio-scsi CD-ROM. Later the installer fails with <https://fedoraproject.org/wiki/Common_F18_bugs#uefi-dvd-fail>, but I think that is an initrd problem. Listed from the emergency shell, "/proc/modules" contains virtio_net and virtio_blk, but not virtio_scsi. I submitted <https://bugzilla.redhat.com/show_bug.cgi?id=864012>. I tested the same with the Windows 8 Consumer Preview ISO (build 8250). It boots. I powered off the virtual machine at the first window ("Windows Setup", language / locale selection). Relevant options on the qemu-kvm command line: -device virtio-scsi-pci,id=scsi0,bus=pci.0,addr=0x5 ^^^^^ -drive file=/filestore/isos/win8/en_windows_8_consumer_preview_debug_checked_build_x64_dvd_811812.iso,if=none,media=cdrom,id=drive-scsi0-0-0-0,readonly=on,format=raw ^^^^^^^^^^^^^^^^^ -device scsi-disk,bus=scsi0.0,channel=0,scsi-id=0,lun=0,drive=drive-scsi0-0-0-0,id=scsi0-0-0-0,bootindex=1 ^^^^^ ^^^^^^^^^^^^^^^^^ Thanks, Laszlo ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
