On Mon, 2012-10-22 at 12:02 -0700, Jordan Justen wrote:
> > > +STATIC
> > > +EFI_STATUS
> > > +SetupLinuxBootParams (
> > > +  IN VOID                   *Kernel,
> > > +  IN OUT struct boot_params *Bp
> > > +  )
> > > +{
> > > +  Bp->alt_mem_k = SIZE_32KB;
> > 
> > This is a bit of legacy code and shouldn't be needed (it shouldn't be in
> > efilinux either).
> 
> Will it possibly allow some older kernels to boot? Or, should I
> just toss it out?

Reading the kernel code, it looks like this value is only used if
there's something wrong with the e820 map, or it's missing. Deleting it
should be fine.

> Thanks for the review Matt!

No problem!

-- 
Matt Fleming, Intel Open Source Technology Center


------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to