Hope this will suffice. -Ari -----Original Message----- From: Jordan Justen [mailto:jljus...@gmail.com] Sent: Thursday, December 13, 2012 11:22 PM To: Ari Zigler Cc: erik.c.bjo...@intel.com; jiang.a....@intel.com; edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [CodeReview] Snp driver binding start return status
You need to supply a commit message, Signed-off-by and Contributed-under for your patch. (See MdeModulePkg/Contributions.txt) -Jordan On Wed, Dec 12, 2012 at 3:38 AM, Ari Zigler <a...@mellanox.com> wrote: > Hi Erik/Jiang, > > > > Can you please review this patch? > > > > Some background: > > While developing a UNDI driver, I found out that the SnpDxe driver's > Start() method might return a success status > > even though the SNP was not successfully installed on the device handle. > > This occurs at a few places in the code where the control flow jumps > to 'NiiError' without invalidating the status code returned. > > > > Ari > > > ---------------------------------------------------------------------- > -------- LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free > Trial Remotely access PCs and mobile devices and provide instant > support Improve your efficiency, and focus on delivering more > value-add services Discover what IT Professionals Know. Rescue > delivers http://p.sf.net/sfu/logmein_12329d2d > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel >
snp_return_error_status.patch
Description: snp_return_error_status.patch
------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
