On Wed, 2013-01-09 at 13:11 -0800, Jordan Justen wrote: > Can you make this a separate patch?
OK. > > + // Clear all but the setup_header > > + SetMem (KernelSetup, 0x1f1, 0); > > + SetMem (((UINT8 *)KernelSetup) + SetupEnd, KernelSetupSize - SetupEnd, > > 0); > > + return EFI_SUCCESS; > > I think this part belongs in SetupLinuxBootParams instead. I'm not going to call SetupLinuxBootParams for the EFI entry point. -- dwmw2
smime.p7s
Description: S/MIME cryptographic signature
------------------------------------------------------------------------------ Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery and much more. Keep your Java skills current with LearnJavaNow - 200+ hours of step-by-step video tutorials by Java experts. SALE $49.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122612
_______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel