On 11 February 2013 16:08, Jordan Justen <jljus...@gmail.com> wrote: > On Mon, Feb 11, 2013 at 12:22 AM, Ryan Harkin <ryan.har...@linaro.org> wrote: >> The attached patch changes the PandaBoardPkg/build.sh script RELEASE >> or DEBUG parameter handling. >> >> Before this patch, build.sh can be called thus: >> ./build.sh >> ./build.sh -b DEBUG >> ./build.sh RELEASE >> >> This patch simplifies the way you pass the debug/release parameter >> into build.sh so that build scripts can simply pass DEBUG or RELEASE, >> without having to create a special case to add the "-b". > > In similar scripts under edk2 we force the use of -b to keep the > script as a wrapper to the edk2-buildtools 'build' command. > (EmulatorPkg, OvmfPkg)
Thanks for the input. I've just realised of course that my mods mean that the "target" can only realistically be "DEBUG" or "RELEASE", whereas, forcing the -b would allow the user to pass in any other (theoretical) target. Leif (CC'd) already commented on this aspect in another discussion I had with him, but it seems I ignored him... I'll re-work the patch ------------------------------------------------------------------------------ Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn more. http://p.sf.net/sfu/sophos-d2d-feb _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
