On 03/05/13 19:22, Kinney, Michael D wrote:
> How about using IoBitFieldWrite16() to avoid the sign issues in the 
> module/lib sources and put the burden on the IoLib.
> 
>       IoBitFieldWrite16  (PcdGet16 (PcdAcpiPmBaseAddress) + 4, 10, 13, 
> SuspendType);
>       IoOr16 (PcdGet16 (PcdAcpiPmBaseAddress) + 4, BIT13);

Sounds good to me. The mask in InternalBaseLibBitFieldOrUint() /
InternalBaseLibBitFieldAndUint() is smart.

Laszlo


------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to