Hi, Gary,
This update looks reasonable. And this case can also apply to "CryptRandItc.c"
and "CryptRandTsc.c" in the same directory. Could you update you patch to cover
all of them?
BTW: In your original patch, there are double "!" and ";". Why?
+ return !!RAND_status();;
Best Regards & Thanks,
LONG, Qin
-----Original Message-----
From: Gary Ching-Pang Lin [mailto:g...@suse.com]
Sent: Friday, May 24, 2013 4:50 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH] CryptoPkg/CryptRand.c: Return the status of random
number generator
Though the comment of RandomSeed() states it should return FALSE if there is
not enough entropy for random generation, the function always returns TRUE.
This commit checks the status of pseudorandom number generator to match the
comment.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Ching-Pang Lin <g...@suse.com>
---
CryptoPkg/Library/BaseCryptLib/Rand/CryptRand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CryptoPkg/Library/BaseCryptLib/Rand/CryptRand.c
b/CryptoPkg/Library/BaseCryptLib/Rand/CryptRand.c
index 4a056e8..f521e64 100644
--- a/CryptoPkg/Library/BaseCryptLib/Rand/CryptRand.c
+++ b/CryptoPkg/Library/BaseCryptLib/Rand/CryptRand.c
@@ -57,7 +57,7 @@ RandomSeed (
RAND_seed (DefaultSeed, sizeof (DefaultSeed));
}
- return TRUE;
+ return !!RAND_status();;
}
/**
--
1.8.1.4
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
