Attached is a patch with the additional changes (beyond silence.patch) that I needed to build on VS2012.
If you fold your silence.patch into your changes, then feel free to
update the commit message as needed.
On Tue, May 28, 2013 at 5:30 PM, Laszlo Ersek <ler...@redhat.com> wrote:
> On 05/28/13 20:55, Jordan Justen wrote:
>> I tried to build this with VS2012, but it failed. (I assume it would
>> fail with other VS as well.)
>
> Sigh. Probably those deliberate UINT_M = UINT_N assignments where M < N.
> I promised that I would pay attention to them, but I must have been
> focusing on what I was actually trying to implement, and these
> truncations were barely a blip on my radar ("yeah that's safe").
>
>> Do you have the capability to build with VS?
>
> I don't, but I just realized I should be able to catch the above
> category with -Wconversion (and by removing -Werror, because
> -Wconversion fires for many other parts of edk2):
>
> .../OvmfPkg/VirtioNetDxe/SnpInitialize.c:125: warning: conversion to 'UINT16'
> from 'int' may alter its value
> .../OvmfPkg/VirtioNetDxe/SnpInitialize.c:146: warning: conversion to 'UINT16'
> from 'int' may alter its value
> .../OvmfPkg/VirtioNetDxe/SnpInitialize.c:226: warning: conversion to 'UINT16'
> from 'int' may alter its value
> .../OvmfPkg/VirtioNetDxe/SnpInitialize.c:266: warning: conversion to 'UINT16'
> from 'int' may alter its value
> .../OvmfPkg/VirtioNetDxe/SnpInitialize.c:270: warning: conversion to 'UINT32'
> from 'long long unsigned int' may alter its value
> .../OvmfPkg/VirtioNetDxe/SnpReceive.c:161: warning: conversion to 'UINT16'
> from 'int' may alter its value
> .../OvmfPkg/VirtioNetDxe/SnpReceive.c:174: warning: conversion to 'UINT16'
> from 'UINT32' may alter its value
>
> I'll turn these into explicit casts.
>
> ... Can you please try the attached patch on top? Does it allow VS to
> compile the module? If so I'll fold the patch in v4.
>
>
>> Do you think anyone with ipxe-virtio or qemu-virtio-net experience
>> might have an interest in looking this over?
>
> I'll send an email to qemu-devel, but don't hold your breath :) There's
> experience galore there, but time, not so much.
>
> Thanks,
> Laszlo
0001-OvmfPkg-VirtioNetDxe-Fix-build-errors-on-VS2013-IA32.patch
Description: Binary data
------------------------------------------------------------------------------ Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET Get 100% visibility into your production application - at no cost. Code-level diagnostics for performance bottlenecks with <2% overhead Download for free and get started troubleshooting in minutes. http://p.sf.net/sfu/appdyn_d2d_ap1
_______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
