It doesn't appear that this patch followed the process described in ShellPkg/Contributions.txt. (Signed-off-by, Contributed-under...)
We are still using this process, right? -Jordan On Tue, Jun 11, 2013 at 3:07 PM, Carsey, Jaben <jaben.car...@intel.com> wrote: > Done. > > > > From: Olivier Martin [mailto:olivier.mar...@arm.com] > Sent: Tuesday, June 11, 2013 10:29 AM > To: Carsey, Jaben > Cc: edk2-devel@lists.sourceforge.net > Subject: [PATCH] ShellPkg: Fixed build with ARM toolchain > Importance: High > > > > Dear ShellPkg maintainer, > > > > Please find the attached patch that fixes the build errors. > > > > Here is the list of some errors I had: > > - tianocore/ShellPkg/Include/ShellBase.h(157,24) : error #1-D: last line of > file ends without a newline > > - tianocore/ShellPkg/Library/UefiShellLevel2CommandsLib/TimeDate.c(670,61) : > error #68-D: integer conversion resulted in a change of sign > > - > tianocore/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c(352,30) > : error #68-D: integer conversion resulted in a change of sign > > - > tianocore/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c(353,30) > : error #68-D: integer conversion resulted in a change of sign > > - tianocore/ShellPkg/Library/UefiShellLevel1CommandsLib/If.c(169,5) : error > #111-D: statement is unreachable > > - tianocore/ShellPkg/Library/UefiShellLevel1CommandsLib/If.c(205,5) : error > #111-D: statement is unreachable > > - tianocore/ShellPkg/Library/UefiShellLevel1CommandsLib/If.c(233,5) : error > #111-D: statement is unreachable > > - tianocore/ShellPkg/Library/UefiShellLevel1CommandsLib/If.c(261,5) : error > #111-D: statement is unreachable > > - tianocore/ShellPkg/Library/UefiShellLevel1CommandsLib/If.c(296,5) : error > #111-D: statement is unreachable > > - tianocore/ShellPkg/Library/UefiShellLevel1CommandsLib/If.c(331,5) : error > #111-D: statement is unreachable > > - tianocore/ShellPkg/Library/UefiShellDriver1CommandsLib/DrvCfg.c(517,5) : > error #111-D: statement is unreachable > > - tianocore/ShellPkg/Library/UefiShellDebug1CommandsLib/EditTitleBar.c(101) > : error C3017: New may be used before being set > > - tianocore/ShellPkg/Library/UefiShellDebug1CommandsLib/EditInputBar.c(131) > : error C3017: New may be used before being set > > - tianocore/ShellPkg/Library/UefiShellDebug1CommandsLib/EditStatusBar.c(98) > : error C3017: New may be used before being set > > - > tianocore/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c(271) > : error C3017: New may be used before being set > > - > tianocore/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/BufferImage.c(551) > : error C3017: New may be used before being set > > (...) > > - tianocore/ShellPkg/Include/Guid/ShellVariableGuid.h(25,7) : error #1-D: > last line of file ends without a newline > > - tianocore/ShellPkg/Include/Guid/ShellAliasGuid.h(25,7) : error #1-D: last > line of file ends without a newline > > - tianocore/ShellPkg/Application/Shell/ConsoleLogger.c(16,41) : error > #177-D: variable "mCrLfString" was declared but never referenced > > > > Thanks, > > Olivier > > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by Windows: > > Build for Windows Store. > > http://p.sf.net/sfu/windows-dev2dev > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel > ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
