On Mon, Jun 24, 2013 at 2:03 AM, Laszlo Ersek <ler...@redhat.com> wrote:
> On 06/18/13 19:45, Laszlo Ersek wrote:
>> On 06/18/13 18:18, Jordan Justen wrote:
>>
>>> Andrew: SmbiosLib exists in EmulatorPkg and not somewhere more common,
>>> because?? I'll assume because it is difficult to add new features to
>>> MdePkg.
>>>
>>> Laszlo, what do you think of using Andrew's
>>> EmulatorPkg/PlatformSmbiosDxe as a basis? Could you review it? It
>>> would be nice if EDK II could provide consistent samples for this sort
>>> of thing.
>>
>> Yes, I peeked at it (and at SmbiosLib) after seeing Andrew's response,
>> and I've checked again now.
>>
>> [...]
>
> Jordan, have you decided about this series? Do you intend to apply it
> as-is, or ask me for minor tweaks, or rather not apply it because you
> think further work would be necessary that I can't offer now? I'm fine
> either way just would like to know.
No one seems to be standing up to defend the unwieldy MiscSubClass
method, so I guess that option is out. (Whew. :)
>From briefly looking over Andrew's solution, and your solution,
unfortunately I think Andrew's looks a little cleaner.
So, based on that, and not wanting to add a 3rd sample model for
SMBIOS in EDK II, I'd like to lean towards adopting what EmulatorPkg
has done.
It seems like it might fit better with something you mentioned, in
that QEMU may eventually pass all the structures to us, so it seems
better to have:
if (Xen) {
AllStructures = GetFromXen();
} else if (Qemu && QemuHasWholeTable) {
AllStructures = GetFromQemuFwCfg();
} else {
AllStructures = EmbeddedInFwLikeEmulatorPkg();
}
Then in a second step, we can potentially dynamically tweak the
structures from the initial set. Isn't that how EmulatorPkg handles
it?
-Jordan
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
