Reviewed-by: Jaben Carsey <jaben.car...@intel.com> Note: the values are not the same. The EFI value has the highest bit set on, while the shell does not. They strongly resemble each other when viewed in hex though.
-Jaben -----Original Message----- From: Gary Ching-Pang Lin [mailto:g...@suse.com] Sent: Monday, July 15, 2013 2:36 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [PATCH] ShellPkg: Assign the proper error status Although the EFI status code is supposed to be the same as the shell status code, it's better to use its own status code. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Ching-Pang Lin <g...@suse.com> --- ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c b/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c index e4f4166..dbf980a 100644 --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c @@ -127,7 +127,7 @@ CascadeDelete( // TempName = AllocateZeroPool(StrSize(Node->FullName) + StrSize(Node2->FullName)); if (TempName == NULL) { - ShellStatus = EFI_OUT_OF_RESOURCES; + ShellStatus = SHELL_OUT_OF_RESOURCES; } else { StrCpy(TempName, Node->FullName); TempName[StrStr(TempName, L":")+1-TempName] = CHAR_NULL; -- 1.8.1.4 ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
