On 07/16/13 20:18, Laszlo Ersek wrote: > On 07/16/13 20:12, Jordan Justen wrote: >> Hmm, I should have mentioned in the commit log that this is a slightly >> simplified version of the code in >> MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c. >> >> It's not great that I'm duplicating code here, but apparently with the >> new KVM READONLY support, we can't wait for DxeIpl to rebuild the >> tables in RAM. > > Can you perhaps still drop "TotalPagesNum" (my point (1))? It is quite > confusing. You could consider that change part of the simplification, > since what's not there can't diverge.
Of course I don't insist on that either, if you want to stick with a verbatim copy. TotalPagesNum is confusing but it does no harm. Reviewed-by: Laszlo Ersek <[email protected]> (I wish people reviewing my code were this flexible! :)) ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
