Thanks Liming,

From: Gao, Liming [mailto:[email protected]]
Sent: Friday, July 19, 2013 12:10 PM
To: Prasad, Parmeshwr; Lu, Ken; Li, Godkey; Ye, Ted; Lin, Sen; Wang, EikanX; 
He, Kenny; Xu, Yi
Cc: Liu, Yingke D; [email protected]; .AR LAR-3 Adolfo Bioy 
Casares Video Conf Rm Author
Subject: RE: [edk2] Recall: GNUMakefile comment need to be improved


  I have committed your change into BaseTools project at 2589.

Thanks
Liming
From: [email protected]<mailto:[email protected]> 
[mailto:[email protected]]
Sent: Thursday, July 18, 2013 5:13 PM
To: Gao, Liming; Lu, Ken; Li, Godkey; Ye, Ted; Lin, Sen; Wang, EikanX; He, 
Kenny; Xu, Yi
Cc: Liu, Yingke D; 
[email protected]<mailto:[email protected]>; 
[email protected]<mailto:[email protected]>
Subject: RE: [edk2] Recall: GNUMakefile comment need to be improved

Hi Liming,

Please find the python tool patch.

Regards
Parmeshwr

From: Gao, Liming [mailto:[email protected]]
Sent: Thursday, July 18, 2013 12:58 PM
To: Prasad, Parmeshwr; Lu, Ken; Li, Godkey; Ye, Ted; Lin, Sen; Wang, EikanX; 
He, Kenny; Xu, Yi
Cc: Liu, Yingke D; 
[email protected]<mailto:[email protected]>; .AR 
LAR-3 Adolfo Bioy Casares Video Conf Rm Author
Subject: RE: [edk2] Recall: GNUMakefile comment need to be improved

Prasad:
  I suggest you also update BaseTool/Source/Python/GNUmakefile and 
BaseTool/Source/C/GNUmakefile to use the consistent style "GUN/Linux".

Thanks
Liming
From: [email protected]<mailto:[email protected]> 
[mailto:[email protected]]
Sent: Wednesday, July 17, 2013 7:58 PM
To: Gao, Liming; Lu, Ken; Li, Godkey; Ye, Ted; Lin, Sen; Wang, EikanX; He, 
Kenny; Xu, Yi
Cc: Liu, Yingke D; 
[email protected]<mailto:[email protected]>; 
[email protected]<mailto:[email protected]>
Subject: RE: [edk2] Recall: GNUMakefile comment need to be improved

Hi Liming,

Please find the respective patches.
Please let me know for any other changes.

Regards
Parmeshwr Prasad

From: Gao, Liming [mailto:[email protected]]
Sent: Wednesday, July 17, 2013 2:57 PM
To: Prasad, Parmeshwr; Lu, Ken; Li, Godkey; Ye, Ted; Lin, Sen; Wang, EikanX; 
He, Kenny; Xu, Yi
Cc: Liu, Yingke D; 
[email protected]<mailto:[email protected]>; .AR 
LAR-3 Adolfo Bioy Casares Video Conf Rm Author
Subject: RE: [edk2] Recall: GNUMakefile comment need to be improved

Yes. Please create the patch and send it for review. If the patch is OK,I could 
help commit it.

From: [email protected]<mailto:[email protected]> 
[mailto:[email protected]]
Sent: Wednesday, July 17, 2013 5:14 PM
To: Gao, Liming; Lu, Ken; Li, Godkey; Ye, Ted; Lin, Sen; Wang, EikanX; He, 
Kenny; Xu, Yi
Cc: Liu, Yingke D; 
[email protected]<mailto:[email protected]>; 
[email protected]<mailto:[email protected]>
Subject: RE: [edk2] Recall: GNUMakefile comment need to be improved


Hi Liming,



I have found similar issue in may files, please go through the attachments.

Please let me know if you want me to create patch for all mentioned files.
File name

Error/Mistake

BeagleBoarsPkg/Tools/GNUmakefile

No

DuetPkg/BootSector/GNUmakefile

No

BaseTool/Source/Python/GNUmakefile

No

BaseTool/Source/C/TianoCompress/GNUmakefile

Yes

BaseTool/Source/C/GenCrc32/GNUmakefile

Yes

BaseTool/Source/C/EfiRom/GNUmakefile

Yes

BaseTool/Source/C/GnuGenBootSector/GNUmakefile

Yes

BaseTool/Source/C/Common/GNUmakefile

Yes

BaseTool/Source/C/GenVtf/GNUmakefile

Yes

BaseTool/Source/C/EfiLdeImage/GNUmakefile

Yes

BaseTool/Source/C/VolInfo/GNUmakefile

Yes

BaseTool/Source/C/VfrCompile/GNUmakefile

Yes

BaseTool/Source/C/GenSec/GNUmakefile

Yes

BaseTool/Source/C/GenFfs/GNUmakefile

Yes

BaseTool/Source/C/Split/GNUmakefile

Yes

BaseTool/Source/C/GNUmakefile

No

BaseTool/Source/C/LzmaCompress/GNUmakefile

Yes

BaseTool/Source/C/BootSecImage/GNUmakefile

Yes

BaseTool/Source/C/GenPage/GNUmakefile

Yes

BaseTool/Source/C/GenFw/GNUmakefile

Yes

BaseTool/Source/C/GenFv/GNUmakefile

Yes

BaseTool/Test/GNUmakefile

Yes

BaseTool/GNUmakefile

No






Regards

Parmeshwr



-----Original Message-----
From: Prasad, Parmeshwr
Sent: Monday, July 15, 2013 11:19 AM
To: [email protected]<mailto:[email protected]>; 
[email protected]<mailto:[email protected]>; 
[email protected]<mailto:[email protected]>; 
[email protected]<mailto:[email protected]>; 
[email protected]<mailto:[email protected]>; 
[email protected]<mailto:[email protected]>; 
[email protected]<mailto:[email protected]>; 
[email protected]<mailto:[email protected]>
Cc: [email protected]<mailto:[email protected]>; 
[email protected]<mailto:[email protected]>; .AR 
LAR-3 Adolfo Bioy Casares Video Conf Rm Author
Subject: Re: [edk2] Recall: GNUMakefile comment need to be improved



Thanks Liming for quick reply.





-----Original Message-----

From: Gao, Liming [mailto:[email protected]]

Sent: Monday, July 15, 2013 10:33 AM

To: Prasad, Parmeshwr; Lu, Ken; Li, Godkey; Ye, Ted; Lin, Sen; Wang, EikanX; 
He, Kenny; Xu, Yi

Cc: [email protected]<mailto:[email protected]>; 
.AR LAR-3 Adolfo Bioy Casares Video Conf Rm Author; Gao, Liming; Liu, Yingke D

Subject: RE: [edk2] Recall: GNUMakefile comment need to be improved



Hi:

   I have committed your change into BaseTools project at 2587.



-----Original Message-----

From: [email protected]<mailto:[email protected]> 
[mailto:[email protected]]

Sent: Monday, July 15, 2013 12:55 PM

To: Lu, Ken; Li, Godkey; Ye, Ted; Lin, Sen; Wang, EikanX; He, Kenny; Xu, Yi

Cc: [email protected]<mailto:[email protected]>; 
[email protected]<mailto:[email protected]>

Subject: Re: [edk2] Recall: GNUMakefile comment need to be improved



Hi All,



Can I know what stage is the changes done by me ?



-----Original Message-----

From: Lu, Ken [mailto:[email protected]]

Sent: Thursday, July 11, 2013 1:56 PM

To: Li, Godkey; Ye, Ted; Lin, Sen; Wang, EikanX; He, Kenny; Xu, Yi

Cc: '[email protected]'

Subject: [edk2] Recall: GNUMakefile comment need to be improved



Lu, Ken would like to recall the message, "[edk2] GNUMakefile comment need to 
be improved".

------------------------------------------------------------------------------

See everything from the browser to the database with AppDynamics Get end-to-end 
visibility with application monitoring from AppDynamics Isolate bottlenecks and 
diagnose root cause in seconds.

Start your free trial of AppDynamics Pro today!

http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk

_______________________________________________

edk2-devel mailing list

[email protected]<mailto:[email protected]>

https://lists.sourceforge.net/lists/listinfo/edk2-devel



------------------------------------------------------------------------------

See everything from the browser to the database with AppDynamics Get end-to-end 
visibility with application monitoring from AppDynamics Isolate bottlenecks and 
diagnose root cause in seconds.

Start your free trial of AppDynamics Pro today!

http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk

_______________________________________________

edk2-devel mailing list

[email protected]<mailto:[email protected]>

https://lists.sourceforge.net/lists/listinfo/edk2-devel



------------------------------------------------------------------------------

See everything from the browser to the database with AppDynamics Get end-to-end 
visibility with application monitoring from AppDynamics Isolate bottlenecks and 
diagnose root cause in seconds.

Start your free trial of AppDynamics Pro today!

http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk

_______________________________________________

edk2-devel mailing list

[email protected]<mailto:[email protected]>

https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to