On 07/23/13 09:20, Dong, Eric wrote:
> =======================
> 
> MdeModulePkg: Remodel SetupBrowserDxe driver
> 
>  
> 
> Current browser driver combines all functions in one driver; it’s hard
> for user to customize the diver for different look and feel. After
> remodel the browser driver, browser driver will be divided into two
> drivers and one library:
> 
> SetupBrowserDxe: maintain the main process from IFR data; it will
> convert the IFR data to display data structure.
> 
> DisplayEngineDxe: maintain the display process, based on the input
> display data structure get from SetupBrowserDxe.
> 
> CustomizedDisplayLib: export some display related interface for user to
> customize, used by DisplayEngineDxe driver.
> 
>  
> 
> After remodeling, user can add their CustomizedDisplayLib or
> DisplayEngineDxe for different user experience.
> 
>  
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> 
> Signed-off-by: Eric Dong <eric.d...@intel.com <mailto:eric.d...@intel.com>>
> 
> =======================
> 
> DuetPkg/Nt32Pkg/OvmfPkg: Update the platform DSC/FDF file to use new
> browser related drivers.
> 
> =======================
> 
>  
> 
> *[Impact]*
> 
> 1.       All related platform need to update dsc and fdf file to include
> new driver and library.

For the OvmfPkg patch: it removes an empty line in OvmfPkgIa32.dsc but leaves 
the corresponding empty lines in the other DSC files intact. Originally I 
wanted to suggest / request that OvmfPkgIa32.dsc be fixed at commit time. 
However:

I wanted to test the main patch (using OVMF), but ran into the following build 
error:

  build.py...
  .../MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf(46): 
error 000E: File/directory not found in workspace
          .../MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.uni

This happens because the posted patch does not contain the binary UNI files, 
only their metadata:

  Index: Library/CustomizedDisplayLib/CustomizedDisplayLib.uni
  ===================================================================
  Cannot display: file marked as a binary type.
  svn:mime-type = application/octet-stream
  Index: Library/CustomizedDisplayLib/CustomizedDisplayLib.uni
  ===================================================================
  --- Library/CustomizedDisplayLib/CustomizedDisplayLib.uni       (revision 0)
  +++ Library/CustomizedDisplayLib/CustomizedDisplayLib.uni       (working copy)

  Property changes on: Library/CustomizedDisplayLib/CustomizedDisplayLib.uni
  ___________________________________________________________________
  Added: svn:mime-type
  ## -0,0 +1 ##
  +application/octet-stream
  \ No newline at end of property

and:

  Index: Universal/DisplayEngineDxe/FormDisplayStr.uni
  ===================================================================
  Cannot display: file marked as a binary type.
  svn:mime-type = application/octet-stream
  Index: Universal/DisplayEngineDxe/FormDisplayStr.uni
  ===================================================================
  --- Universal/DisplayEngineDxe/FormDisplayStr.uni       (revision 0)
  +++ Universal/DisplayEngineDxe/FormDisplayStr.uni       (working copy)

  Property changes on: Universal/DisplayEngineDxe/FormDisplayStr.uni
  ___________________________________________________________________
  Added: svn:mime-type
  ## -0,0 +1 ##
  +application/octet-stream
  \ No newline at end of property

Can you convince SVN to emit a base64 encoded dump?

Thanks,
Laszlo

------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to